feat(azure): support azure blob container storage #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add azure implementation, and register with scheme "azure" - update test suite to use azure client when "azure" adapter is requested - add `pathy[azure]` extras to setup.py - remove "list_buckets" from BucketClient classes BREAKING CHANGE: This removes an internal bit of code that allowed for enumerating buckets in certain situations. The API was impossible to reach without going indirectly through the glob functionality, and it's not clear that the codepaths were ever reached outside of specific unit testing situations. If there's an explicit need for listing buckets, we can add a top-level API for it.
3efec2d
to
0b2ebc7
Compare
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #93 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 5 6 +1
Lines 1004 1105 +101
==========================================
+ Hits 1004 1105 +101
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 16, 2022
# [0.8.0](v0.7.1...v0.8.0) (2022-11-16) ### Features * **azure:** support azure blob container storage ([#93](#93)) ([9624856](9624856)) ### BREAKING CHANGES * **azure:** This removes an internal bit of code that allows for enumerating buckets in certain situations. The API was impossible to reach without going indirectly through the glob functionality, and it's unclear whether the code paths were ever reached outside of specific unit testing situations. If there's an explicit need for listing buckets, we can add a top-level API for it.
|
🎉 This PR is included in version 0.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pathy[azure]extras to setup.pyBREAKING CHANGE: This removes an internal bit of code that allows for enumerating buckets in certain situations. The API was impossible to reach without going indirectly through the glob functionality, and it's unclear whether the code paths were ever reached outside of specific unit testing situations. If there's an explicit need for listing buckets, we can add a top-level API for it.