Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with monolog/monolog v2.7.0 #93

Closed
adamj88 opened this issue Jun 9, 2022 · 1 comment
Closed

Incompatible with monolog/monolog v2.7.0 #93

adamj88 opened this issue Jun 9, 2022 · 1 comment

Comments

@adamj88
Copy link
Contributor

adamj88 commented Jun 9, 2022

Today, monolog/monolog was updated to v2.7.0 where they added an additional $datetime parameter to the addRecord method in: https://github.com/Seldaek/monolog/releases/tag/2.7.0

Since this module requires >=2.0.0 of monolog an error is produced:

Warning: Declaration of JustBetter\Sentry\Plugin\MonologPlugin::addRecord(int $level, string $message, array $context = Array): bool should be compatible with Monolog\Logger::addRecord(int $level, string $message, array $context = Array, ?Monolog\DateTimeImmutable $datetime = NULL): bool in vendor/justbetter/magento2-sentry/Plugin/MonologPlugin.php on line 54

Ref:

@adamj88 adamj88 changed the title Incompatible with monolog/monolog v3.7.0 Incompatible with monolog/monolog v2.7.0 Jun 9, 2022
@indykoning
Copy link
Member

This has now been fixed and released as version 3.1.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants