Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to set Magento modes that send errors to Sentry #4

Closed
ctadlock opened this issue Apr 8, 2018 · 6 comments
Closed

Ability to set Magento modes that send errors to Sentry #4

ctadlock opened this issue Apr 8, 2018 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@ctadlock
Copy link

ctadlock commented Apr 8, 2018

Currently errors are only sent to Sentry if Magento is in production mode. That's great for when the site is running, but not helpful during development. There should be an admin setting to allow for errors to be sent for any/all Magento modes.

@ctadlock
Copy link
Author

ctadlock commented Apr 8, 2018

In addition, the current Magento mode should be sent over to Sentry so that any filtering can happen there.

@rakibabu rakibabu self-assigned this Apr 9, 2018
@rakibabu rakibabu added the enhancement New feature or request label Apr 9, 2018
@rakibabu rakibabu reopened this Apr 17, 2018
@rakibabu
Copy link
Contributor

Hi @ctadlock ,

Thanks for the suggestion, I'll implement this enhancement soon.

Kind regards,

Rakhal Imming

@ctadlock
Copy link
Author

ctadlock commented Apr 27, 2018

I tried out your latest code for sending a test event. Im getting this error when your admin config page loads. 404 on testsentry.js

image

image

@ctadlock
Copy link
Author

^ static content is not deployed on this site because its in development; which is the whole purpose of this feature.

@rakibabu
Copy link
Contributor

rakibabu commented Apr 30, 2018

Hi @ctadlock ,

I've added an option in de latest code to fix your issue(version 0.2.0) with testing this module on development mode. There's an option in the backend Send errors in development mode which you can turn on to test this module.

Static content is not required to deploy testsentry.js. Please ensure you've the option Allow Symlinks turned on in your magento 2 installation when on development mode.

Please let me know if the module works as expected, if not please reopen this issue.

Kind regards,

Rakhal Imming

@ctadlock
Copy link
Author

@rakibabu I am still unable to get this to work. Enabling Allow Symlinks fixed the JS error, but clicking the send sentry test event button does not send an event to Sentry, even though it says Success.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants