-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deployment configuration ignored when "Environment Configuration Enabled" set to "No" #128
Comments
You're absolutely right on where the problem is coming from. Perhaps we should disable all |
If someone else is experiencing this problem, you can work around this issue by deleting the entry for @indykoning, what happened to us was I wanted to enable JavaScript tracking. So I've changed "Enable Javascript Tracking" in the admin config to "Yes" and clicked on "Save". This broke the Sentry integration completely, as the environment configuration field was saved too. And there is no way to fix it without either access to the CLI or the database. |
Bug: What is the current behavior?
When store configuration "Environment Configuration Enabled" is saved to "No", the deployment configuration is ignored and no data is sent to Sentry.
This only happens when there is an entry like this in the
core_config_data
table:sentry/environment/enabled 0
Bug: What is the expected behavior?
When store configuration "Environment Configuration Enabled" is saved to "No", the deployment configuration is used instead.
Bug: What is the proposed solution?
I've traced this bug to
\JustBetter\Sentry\Helper\Data::collectModuleConfig
:If
getValue()
returnsnull
the second check is performed and the configuration is loaded from the deployment config. But ifgetValue()
returns"0"
, then"0"
will be saved to$config['enabled']
, which means the module will be treated as disabled, regardless of the deployment config.What is the version of Magento and of Sentry extension you are using? Always use the latest version of the extension one before opening a bug issue.
PHP 8.2
Magento 2.4.6-p4
Sentry extension 3.5.2
The text was updated successfully, but these errors were encountered: