-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TargetOptions parameter is not there with custom-esbuild #1690
Labels
bug
Something isn't working
Comments
shisukei
changed the title
TargetOptions parameter is undefined with custom-esbuild
TargetOptions parameter is not there with custom-esbuild
Feb 23, 2024
I just got the same error and the arguments seem to have change. The 1st argument should be |
Seems packages/custom-esbuild/src/application/index.ts::30 should be something like
But options param seems only contain target options, not configuration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the Bug
Hi,
I am currently working on upgrading an Angular 16 application to Angular 17 and I would like to use esbuild.
My application requires index.html transformation. This transformation relies on data from the targetOptions parameter.
With version 16, I was using
@angular-builders/custom-webpack
and it was working fine.Unfortunately, with
@angular-builders/custom-esbuild
, the targetOptions are not present during the transformation. Instead, it's the content of the index file.Yet the documentation indicates that targetOptions should be accessible.
Minimal Reproduction
Just creating a new Angular 17 application (via ng new), and following the instruction of the doc :
@angular-builders/custom-esbuild
as a dev dependency@angular-devkit/build-angular:application
with@angular-builders/custom-esbuild:application
and@angular-devkit/build-angular:dev-server
with@angular-builders/custom-esbuild:dev-server
in angular.jsonHere is the result on ng build / ng serve :
Expected Behavior
TargetOptions should be there. Or at least, documentation needs an update.
Environment
The text was updated successfully, but these errors were encountered: