-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(payments): add api locking for payments core #1898
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NishantJoshi00
requested changes
Aug 23, 2023
dracarys18
requested changes
Aug 23, 2023
jarnura
requested changes
Aug 24, 2023
…nts, remove feature flag
Abhicodes-crypto
force-pushed
the
api-locking
branch
2 times, most recently
from
September 21, 2023 08:46
ed33829
to
2eb2460
Compare
inventvenkat
requested changes
Sep 21, 2023
inventvenkat
requested changes
Sep 21, 2023
inventvenkat
previously approved these changes
Sep 22, 2023
inventvenkat
approved these changes
Sep 23, 2023
jarnura
approved these changes
Sep 25, 2023
NishantJoshi00
approved these changes
Sep 25, 2023
dracarys18
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR introduces an API locking framework and uses it with the core payments flow. For now both are under the
locking
feature flag. After thorough testing they can be moved under release feature.Problem statement:
API locking prevents that by locking the flow.
TODO :
Acquired
or gives error and only over acquired statusrelease_lock
is implemented.Additional Changes
Motivation and Context
How did you test it?
Monitored redis if the locks are getting created or not.
Webhooks testing still in progress
Checklist
cargo +nightly fmt --all
cargo clippy