refactor(core): Add 'redirect_response' field to CompleteAuthorizeData #1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chikke srujan <[email protected]>
redirect_response field to CompleteAuthorizeData redirect_response field to CompleteAuthorizeData
redirect_response field to CompleteAuthorizeData
jarnura
requested changes
May 22, 2023
crates/api_models/src/payments.rs
Outdated
|
|
||
| /// Allowed payment method types for a payment intent | ||
| #[schema(value_type = Option<Vec<PaymentMethodType>>)] | ||
| pub allowed_payment_method_types: Option<Vec<api_enums::PaymentMethodType>>, | ||
| } | ||
|
|
||
| #[derive(Default, Debug, Eq, PartialEq, serde::Deserialize, serde::Serialize, Clone, ToSchema)] | ||
| pub struct RedirectResponse { | ||
| pub param: Option<String>, |
crates/router/src/types.rs
Outdated
| pub browser_info: Option<BrowserInformation>, | ||
| pub connector_transaction_id: Option<String>, | ||
| pub connector_meta: Option<serde_json::Value>, | ||
| } | ||
|
|
||
| #[derive(Debug, Clone)] | ||
| pub struct CompleteAuthorizeRedirectResponse { | ||
| pub params: Option<String>, |
Signed-off-by: chikke srujan <[email protected]>
SanchithHegde
approved these changes
May 22, 2023
jarnura
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
add redirect_response field to CompleteAuthorizeData instead of payload
Additional Changes
Motivation and Context
Previously we were sending only payload in
CompleteAuthorizedData, for connectorauthorizedotnetquery_params are required. In this PRredirect_responseis added inCompleteAuthorizedDatawhich contains both query_params and payload.How did you test it?
Bluesnap goes through complete authorize flow for 3ds payment ,which uses payload in redirect response .So ,i have tested this connector in postman.
Check
list
cargo +nightly fmt --allcargo clippy