-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JupyterHub and Jupyter got into the open-source program for dockerhub! #559
Comments
Great news, Erik, thank you! When (and if) it becomes possible, please add me to the DockerHub team as well :) |
hooray! thanks @mathbunnyru for making an application for the team! |
The application was easy to write, but to even find the form to apply etc we had to speak with dockerhub - the button to apply was missing from the website ;D Thank you @mathbunnyru for making this happen! Adding Ayaz to hub.docker.com's Jupyter organization
So far I can't invite members to the JupyterHub organization where I have owner permissions, but I assume we are enabled doing that soon. When such permissions is granted for the jupyter and jupyterhub organization I hope we can add members. @minrk are you an owner in the jupyter organization on hub.docker.com? Adding image repository descriptionsAs described in the email, they want us to add descriptions to the image repositories linking out to the source code etc. That makes perfect sense to me and I'm happy to work on getting that done. But I'd like to clear out a few image repositories that I don't think are used any more. @jupyterhub/jupyterhubteam do you agree its okay to delete the image repositories aged more than 4+ years old as seen in the screenshots below? |
Can you get any stats on when images were last pulled? e.g. for the images with 100K+ pulls, how many pulls were in the past year? |
Can you get pulls/month? If an image is pulled once a month by some automated external security scanning company we don't care, but if it's 100/week we should probably keep them. |
How about a cutoff of 1000 total pulls? Delete if there are fewer, document if there are more? |
|
tljh-circleci-base-image was used in tljh CI, but not anymore. That's clearly for internal use only, and safe to remove since we aren't using it. |
Is there a benefit to deleting it? I don't really understand proactively deleting published artifacts from the internet. |
To be clear - I think we should leave it alone because it was part of a published release, and already has a readme, Dockerfile, etc. If it were only an interim image, deleting makes sense to me. |
Since its part of a published release, let's retain it. I can document whats needed in the jupyterhub org on dockerhub now given your findings! I find cleaning up unused things etc is relevant overall though. An accumulation of historic parts can be problematic, but not always. For example when its clear something is outdated its far better when its not clear. It can be quite clear that code only found in git history or a pypi release superseeded by a newer version is outdated, but its less clear if we have stopped pushing new versions of a docker image in favor of another name or similar. I remember how finding the tljh-circleci image made me think tljh was tested like that still even though it wasn't - and that made me onboard myself to tljh's CI system a bit slower. Not a big deal, but I really appreciate complexity reduction whenever possible for reasons like that. |
Thanks, I appreciate that perspective and all your efforts on reducing complexity and helping people contribute! |
I see that we have now got 10 members in the jupyterhub organization on hub.docker.com, maybe also for the jupyter organization then? |
If so, could you confirm if we got 10 members allowed in the jupyter dockerhub organization at this point? I think we have! I'd like to help get @mathbunnyru access to help with jupyter/docker-stacks maintenance, for example to define the new proposed image repository in jupyter/docker-stacks#1809. |
@mathbunnyru Is your Docker ID the same as your GitHub ID? If so, I can invite you. |
@parente yes! 👍 |
@mathbunnyru Invite sent. |
@parente could you take a look, please? |
@mathbunnyru added! |
I'll go for a close on this issue, its too large and we have resolved a lot of things already! Thanks everyone!!! |
Thank you everyone for your help! I hope I will be able to help the community even better now. |
Thanks @mathbunnyru for your extraordinary patience through this process! |
@mathbunnyru advocated for a submission into DockerHub's Open Source program. An application was submitted and has now been accepted!
I received this email:
The text was updated successfully, but these errors were encountered: