Skip to content
This repository has been archived by the owner on Jan 24, 2018. It is now read-only.

Hardcoded command "/bin/sh -c" breaks containers with entrypoints #209

Open
parente opened this issue Jan 21, 2016 · 1 comment
Open

Hardcoded command "/bin/sh -c" breaks containers with entrypoints #209

parente opened this issue Jan 21, 2016 · 1 comment

Comments

@parente
Copy link
Member

parente commented Jan 21, 2016

The command prefix here:

https://github.com/jupyter/tmpnb/blob/master/dockworker.py#L112

causes problems when container images have custom entrypoints like the one here:

https://github.com/jupyter/docker-stacks/blob/master/minimal-kernel/Dockerfile#L46

Opening this for reference since I routinely forget about this problem. Maybe there's a fix we can do in tmpnb to support the current default plus the custom entrypoint. Or maybe tmpnb README puts a stake in the ground about how the container entrypoint needs to be crafted.

@rgbkrk
Copy link
Member

rgbkrk commented Jan 22, 2016

Ah and that one was put it in to make it easier to launch the current notebooks. I'm ok with overriding this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants