Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bullet point alignment in bibliography #3704

Closed
jd-foster opened this issue Mar 8, 2024 · 9 comments · Fixed by #3706
Closed

Bullet point alignment in bibliography #3704

jd-foster opened this issue Mar 8, 2024 · 9 comments · Fixed by #3706

Comments

@jd-foster
Copy link
Collaborator

Something strange is happening with the alignment of the bullets (only visible in dark mode??)

image

Feel free to close, this is possibly a Documenter issue.

@odow
Copy link
Member

odow commented Mar 8, 2024

cc @goerz have you noticed this before?

Link: https://jump.dev/JuMP.jl/stable/background/bibliography/

@goerz
Copy link
Contributor

goerz commented Mar 8, 2024

I have not noticed this before (maybe because I don’t use dark mode), but seems like a CSS problem. I’ll have a look

@goerz
Copy link
Contributor

goerz commented Mar 8, 2024

I'm also seeing this in https://juliadocs.org/DocumenterCitations.jl/stable/gallery/#author_year_style

So it's not specific to any kind of JuMP settings, but something that should be fixed in the "recommended" CSS. The bullet point is just supposed to be invisible, but it seems to clash with something in the dark mode CSS.

@goerz
Copy link
Contributor

goerz commented Mar 8, 2024

Yeah, documenter-dark.css is overriding the list-style: none in citations.css with list-style: disc outside.

CleanShot 2024-03-08 at 12 23 34@2x

I guess it's because the documenter-dark.css gets loaded later? Maybe we have to mark the citatations.css settings as "important".

@goerz
Copy link
Contributor

goerz commented Mar 8, 2024

Adding important to the citations.css seems to do the trick:

.citation ul {
 padding: 0 0 2.25em 0;
 margin: 0;
 list-style: none !important;}

I'll make a DocumenterCitations release with a new recommendation for the CSS, but you'll have to change the citations.css file manually in your existing documentation (probably directly on the gh-pages branch).

@goerz
Copy link
Contributor

goerz commented Mar 8, 2024

This is "fixed" in the DocumenterCitations release v1.3.3 I just made. Although updating DocumenterCitations won't really do anything for you: you'll have to modify https://github.com/jump-dev/JuMP.jl/blob/master/docs/src/assets/citations.css (and also the citations.css in existing deployed versions of your documentation)

@shayandavoodii
Copy link

Would adding the !important to the citations.css of the dev version also result in fixing the upcoming versions? I want to ensure that no other .css modification is required for future releases, and the change will automatically be applied to the upcoming releases.

@odow
Copy link
Member

odow commented Mar 10, 2024

Would adding the !important to the citations.css of the dev version also result in fixing the upcoming versions?

#3706 edits master. That'll fix the dev docs and all future versions. It won't fix already published versions.

@shayandavoodii
Copy link

Would adding the !important to the citations.css of the dev version also result in fixing the upcoming versions?

#3706 edits master. That'll fix the dev docs and all future versions. It won't fix already published versions.

Thank you so much. I got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

4 participants