Updates Beaker tests for Vault #77
Conversation
petems
commented
Jun 13, 2017
- Updates example spec for beaker (invalid syntax)
- Changes module install to install archive module
- Adds new Travis acceptance jobs
- Updates example in README (invalid syntax)
e214dd9
to
4be5a58
Compare
|
@jsok Build is green now 😄 You got time to review? Cos I've got some other PR's and fixes I want to submit, but I want to wait until the acceptance tests are working before I implement 👍 |
Gemfile
Outdated
|
|
||
| RUBY_2_OR_NEWER = RUBY_VERSION >= '2.0.0' | ||
| def location_for(place, fake_version = nil) |
There was a problem hiding this comment.
What is this for? I can see it used anywhere.
There was a problem hiding this comment.
There's some reason I forget, removed! 😓
.travis.yml
Outdated
| - sudo: required | ||
| services: docker | ||
| rvm: '2.3.3' | ||
| env: PUPPET_INSTALL_VERSION="1.5.2" PUPPET_INSTALL_TYPE=agent BEAKER_set="centos-6-x86_64-docker" |
There was a problem hiding this comment.
1.5.2 refers to the version of the puppet-agent? This is fairly old now: https://docs.puppet.com/puppet/4.10/about_agent.html#release-contents-of-puppet-agent-1x
There was a problem hiding this comment.
I think because at the time I wrote the original version of these specs, Puppet 4.5 was what was in the LTS release of Puppet Enterprise, I can update it now 😄
* Updates example spec for beaker (invalid syntax) * Changes module install to install archive module * Adds new Travis acceptance jobs * Updates example in README (invalid syntax) * Updates Gemfile
|
Great will merge now. |