Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert NoMatch.tsx to NoMatch.ts #556

Closed
martinfrances107 opened this issue Nov 23, 2018 · 3 comments
Closed

Convert NoMatch.tsx to NoMatch.ts #556

martinfrances107 opened this issue Nov 23, 2018 · 3 comments

Comments

@martinfrances107
Copy link
Contributor

This is just a tiny change

We have recently converted files with a JSX extension to have a JS extension.

In another issue dawehner has provided a link to the reasons why...

It looks like there is a disagreement between airbnb and people working on react itself, see facebook/create-react-app#87 (comment)

The NO JSX policy is fine with me ... This is a small followup we should also have a NO TSX policy
NoMatch tsx the only file to be changed.
@dawehner
Copy link
Contributor

👍

@martinfrances107
Copy link
Contributor Author

Here is the associate PR #557

-- for some reason the auto linking between PR and main issue failed.. hmmm

@martinfrances107
Copy link
Contributor Author

The merge is in .. thank you.

@martinfrances107 martinfrances107 mentioned this issue Dec 28, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dawehner @martinfrances107