Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot set certain element style properties to empty #3372

Closed
yyx990803 opened this issue May 20, 2022 · 1 comment · Fixed by jsdom/cssstyle#162
Closed

Cannot set certain element style properties to empty #3372

yyx990803 opened this issue May 20, 2022 · 1 comment · Fixed by jsdom/cssstyle#162
Labels
css

Comments

@yyx990803
Copy link

yyx990803 commented May 20, 2022 •
edited
Loading

Basic info:

  • Node.js version: 16.13.2
  • jsdom version: 19.0.0

Minimal reproduction case

This works as expected:

const el = document.createElement('div')
el.style.margin = '10px'
console.log(el.style.margin) // '10px'

el.style.margin = ''
console.log(el.style.margin) // ''

This does NOT:

const el = document.createElement('div')
el.style.marginLeft = '10px'
console.log(el.style.marginLeft) // '10px'

el.style.marginLeft = '20px'
console.log(el.style.marginLeft) // '20px'

el.style.marginLeft = ''
console.log(el.style.marginLeft) // '20px'

Note after setting marginLeft to empty, the value on style is still '20px'.

How does similar code behave in browsers?

You can just paste the code in the browser console to witness the expected behavior: el.style.marginLeft should return empty string.
@yyx990803 yyx990803 changed the title Setting individual element style properties sometimes doesn't Setting individual element style properties sometimes doesn't work May 20, 2022
@yyx990803 yyx990803 changed the title Setting individual element style properties sometimes doesn't work Cannot set certain element style properties to empty May 20, 2022
@sombriks
Copy link

yep it works on browser
Captura de tela de 2022-05-20 02-22-15
but not on jsdom
Captura de tela de 2022-05-20 02-23-02

@domenic domenic added the css label Oct 1, 2022
@ska-kialo ska-kialo mentioned this issue Apr 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow removing indiviual margin/padding properties kialo/cssstyle
3 participants
@yyx990803 @sombriks @domenic