Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest#compile does not support regExp files patterns. #216

Open
olpapchenko opened this issue Jan 24, 2016 · 0 comments
Open

Manifest#compile does not support regExp files patterns. #216

olpapchenko opened this issue Jan 24, 2016 · 0 comments

Comments

@olpapchenko
Copy link

Hi,
<Manifest#compile> can not be used with RegExp patterns for files. While passing RegExp to the compile method we will get exception, because it assumes that files array can contain only strings. Here is the problem https://github.com/nodeca/mincer/blob/master/lib/mincer/manifest.js#L217. <isAbsolute> iterator is called for each file entry, if calling it with regExp obviously we will get an error. Can this be fixed by simpy filtering regExps from files array before calling <isAbsolute> method? I have tried locally and after that i was able to use RegExps at the file array for <Manifest#compile>

@olpapchenko olpapchenko changed the title While using Manifest#compile does not support regExp files patterns. Manifest#compile does not support regExp files patterns. Jan 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant