This repository has been archived by the owner on Feb 8, 2023. It is now read-only.
Change the package names to be specific for where the project comes from #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
used this package definition at first in hope that, if in the future the domain is acquired, then there would be no drastic refactor to the codebase. As from gh-6, I realized that if Maven Central will not allow the artifactId to have a domain reference that is not owned by the artifact owners, then there's no reason to do the same with the package names throughout the project. Also, if the user sees a package name starting as com.github.jscookie in some artifact, then he will know exactly where to look for the project.
dddd0f9
to
485030e
Compare
FagnerMartinsBrack
added a commit
that referenced
this pull request
Aug 1, 2015
The jscookie.org domain is not owned by @FagnerMartinsBrack or @carhartl. I used this package definition at first in hope that, if in the future the domain is acquired, then there would be no drastic refactor to the codebase. As from gh-6, I realized that if Maven Central will not allow the artifactId to have a domain reference that is not owned by the artifact owners, then there's no reason to do the same with the package names throughout the project. Also, if the user sees a package name starting as com.github.jscookie in some artifact, then he will know exactly where to look for the project. Closes gh-7.
FagnerMartinsBrack
added a commit
that referenced
this pull request
Aug 2, 2015
The test files had some package references that were not updated in the refactor done in gh-7
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jscookie.org domain is not owned by @FagnerMartinsBrack or @carhartl. I
used this package definition at first in hope that, if in the future the
domain is acquired, then there would be no drastic refactor to the
codebase.
As from gh-6, I realized that if Maven Central will not allow the
artifactId to have a domain reference that is not owned by the artifact
owners, then there's no reason to do the same with the package names
throughout the project.
Also, if the user sees a package name starting as
com.github.jscookiein some artifact, then he will know exactly where to look for the project.