Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default config to use journal key #1202

Closed
micahellison opened this issue Feb 27, 2021 · 1 comment · Fixed by #1594
Closed

Change default config to use journal key #1202

micahellison opened this issue Feb 27, 2021 · 1 comment · Fixed by #1594
Labels
enhancement New feature or request 📌 This can't go stale ready for pr Okay to start work. Feel free to ask questions.

Comments

@micahellison
Copy link
Member

Feature Request

Use Case/Motivation

When a user runs jrnl for the first time, it creates a config file with a default journal based on the user's input. That shows up under the journals key as default: (path) like so:

journals:
  default: C:\Users\micah\journal.txt

This is fine, except it can be a bit confusing for users that want to add per-journal configuration elements, e.g. different templates for different journals as seen in #1152. It would be easier to modify if the journal key was used instead, like so:

journals:
  default:
    journal: C:\Users\micah\journal.txt
@stale
Copy link

stale bot commented Jun 19, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Inactive issue: will be closed soon if no activity label Jun 19, 2021
@micahellison micahellison added the 📌 This can't go stale label Jun 19, 2021
@stale stale bot removed the stale Inactive issue: will be closed soon if no activity label Jun 19, 2021
@micahellison micahellison added the ready for pr Okay to start work. Feel free to ask questions. label Sep 3, 2022
@wren wren closed this as completed in #1594 Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 📌 This can't go stale ready for pr Okay to start work. Feel free to ask questions.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants