excel: replace clone with take in hot loop

jqnatividad · Mar 27, 2024 · 8496157 · 8496157
1 parent 80bd767
commit 8496157
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/cmd/excel.rs b/src/cmd/excel.rs
@@ -723,8 +723,10 @@ pub fn run(argv: &[&str]) -> CliResult<()> {
  trimmed_record.clear();
  }
 
- processed_chunk.push(record.clone());
- record.clear();
+ // we use mem::take here to avoid a clone/allocation of the record
+ // it also has the nice side-effect of clearing the record, so we don't
+ // need to call clear() on it.
+ processed_chunk.push(std::mem::take(&mut record));
  }
  processed_chunk
  })