-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Crash when geoclue is not installed #186
Comments
Firstly thank you for trying out Go Hass Agent and also reporting this issue! I can see what is the issue here, I recently performed some code clean-up and refactoring that's introduced this bug. Hopefully, commit aeca410 fixes the crash and commit acac8d7 adds the functionality to not start a location sensor when not running on a laptop. Would you be able to try checking out the latest source, building and seeing if that fixes the issue for you? Would it also be useful if the releases contained a binary archive? i.e., just an amd64 binary in a tar.gz? You'd still need to install the additional libraries the agent needs but this might make it easier on distros I don't have a package for? |
Just following up, v.9.4.0 should fix the crash observed here. Also, a location sensor won't be created unless you are running on a laptop. Please try out the latest version and reply back with the results when you can! |
I pulled the latest ( As far as the location sensor being created, I am on a laptop, but I use it as a desktop - it's always plugged into an external keyboard, mouse, and monitor, and I don't move it. It would still be nice to be able shut off the location sensor, but I think #171 covers that. :) |
Go Hass Agent Version
Describe the bug
Crash at startup (
SIGSEGV
) when Geoclue2 is not installed.To Reproduce
Steps to reproduce the behaviour:
go-hass-agent register --force
)go-hass-agent run
Expected behaviour
It shouldn't crash, and instead should just ignore the location sensor.
Logs
Desktop:
Additional context
I encountered this because there's no
go-hass-agent
package on Void Linux, and when building manually, the documentation doesn't mention Geoclue2 being a prerequisite. Even after installing it, I'm unable to get Geoclue2 to actually run, so I'm still blocked by this error. (some of the specifics changed, of course - it now saysLaunch helper exited with unknown return code 253
instead ofThe name org.freedesktop.GeoClue2 was not provided by any .service files
but the logs otherwise look practically identical)For use on a desktop, it doesn't make sense to require a location sensor. (related to the first part of #171)
The text was updated successfully, but these errors were encountered: