Parse time durations containing commas #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdk
requested changes
Dec 13, 2020
There was a problem hiding this comment.
Thank you so much for your contribution @vistaarjuneja! So sorry it took so long to review.
I think this is a great change, and a good find too! I only had one small suggestion to make handling values with commas more uniform. Please take a look, and I'll be happy to merge after that.
Cheers!
|
Hi @vistaarjuneja, wanted to reach out again! Did you have any thoughts on the above feedback? If things were addressed I would be happy to merge. 😄 Thanks again, cheers! |
3d9f6d4
to
f1a1dbc
Compare
|
Totally missed the previous message. Thanks for reviewing! Let me know if it looks better now |
joshdk
approved these changes
Dec 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #38
For tests longer than 17 minutes, the duration field goes into 4 digits. The maven surefire plugin outputs this in a comma separated format, e.g, 1,234.56. We should remove commas before trying to parse the duration field. Ref: junit-team/junit5#1381