-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discussion: error_reporting(0) rule #98
Comments
Generally, when a developer wants to hide notices and warnings, the extension includes There are valid It is difficult to decide what to do with I think that we must keep the rule, but improve it to detect any usage of |
Currently this rule detects just an
error_reporting(0)
code only (note:error_reporting(1-1)
orerror_reporting( 0 )
are passed). I suggest to revise this rule to detect usage of any function that may affect PHP code execution (independently of arguments passed):I'm not sure about:
set_time_limit
: it is frequently used in the case of heavy server-side processing, I'd keep it as allowed one,set_include_path
: may be used to run some legacy libraries,There may be rarely cases where
ini_set
is necessary, so it may be allowed (if followed by restoring settings back before script returns to Joomla).What do you think?
The text was updated successfully, but these errors were encountered: