-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect android_12 check for image_dark #347
Comments
Thanks for the ticket and checking into this. I will address this in the next release. |
Hi @jonbhanson , |
@sureace Simply delete the check for now. |
I will push an update out soon to resolve this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Incorrect error message check when trying to set android_12
image_dark
value.The following configuration:
Results in:
"Your
flutter_native_splash
section containsandroid_12:icon_background_color_dark
but does not contain acolor_dark
or abackground_image_dark
."To Reproduce
Copy config above and:
flutter pub run flutter_native_splash:create
Expected behavior
No error is reported.
Additional context
Having a look at the code, this sections looks wrong (https://github.com/jonbhanson/flutter_native_splash/blob/master/lib/cli_commands.dart l309):
It's looking for a
icon_background_color_dark
config in the top level, but there is no such config, it is under theandroid_12
namespace. Second, the error message is wrong (most likely copied from the first check just above).I am not exactly sure what this check is supposed to ensure though.
The text was updated successfully, but these errors were encountered: