Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make android_disable_fullscreen defaults to false #122

Closed
Ascenio opened this issue Jan 24, 2021 · 0 comments
Closed

Make android_disable_fullscreen defaults to false #122

Ascenio opened this issue Jan 24, 2021 · 0 comments

Comments

@Ascenio
Copy link

Ascenio commented Jan 24, 2021

Reasons:

  1. It's not expected to be enabled by default, as it hides the StatusBar, and generally if the bar goes away we think there's a bug as it wasn't intended (we think the package will just generate the splash, but not touch the StatusBar).
  2. It makes TextFields not work properly. Look bellow:

Recently I found a project which used flutter_native_splash and didn't set android_disable_fullscreen. It caused TextFields to not be centralized on the screen once tapped. I fixed it by removing <item name="android:windowFullscreen">true</item> on the android/app/src/main/res/values/styles.xml, and so the TextFields returned to work. It was only later I figured out you could disabled by setting android_disable_fullscreen: false, my bad. However I don't think most use cases require fullscreen, so I would advise to turn it off by default to prevent confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant