-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SoundSeer stops functioning when Mac awakes from sleep #37
Comments
Hi there, thank you for using SoundSeer and for reporting this issue. Right now I am unable to replicate this. A couple questions:
|
1 - I built from source |
I see, thank you. In that case, it seems that there are too many menu bar icons. Unfortunately, Apple doesn't give me much leverage in this case--the operating system will kick icons off the menu bar and I am unable to control that. (If I remember correctly, it kicks off older ones first.) Right now, I think the best I can do is what you're seeing--minimize the app to just a small icon to display a warning message. If you have any other suggestions though, I am happy to hear them. |
I just did some testing around with it - it indeed is because there's too many menu bar icons for the laptop screen, even though I'm on just the display and it has more than enough space for it as it displays just fine with a ton of icons on display. On ideas - I'm not sure how it works but going off the error message and the fact it asks to restart because of the lack of space, maybe when it's on lack of space every 10/15s or so try and calculate the space again? Since it only happens with the larger display I'm guessing the calculation is based on the laptop screen when restarting before it loads on display and then gives up once it fails |
Oh, I see. You're opening SoundSeer when the laptop is the main display, then you switch over to your monitor? It'll be a bit tricky, but what I can do is add a button to the menu to manually recalculate width. The issue is that I can only determine the max width when SoundSeer disappears, so if I run it at an interval, it will create a flashing animation when it disappears and appears again. |
No, I never open the laptop. But since the problem is because there's no space on the laptop screen and it gets triggered on the display, I'm assuming when the Mac is waking up, the calculation gets done with the laptop display (even though it's not in use) before it loads on the display |
Okay. Honestly, I'm not really sure how to address that. However, you can make the following change to
Apple is giving me a hard time about Apple Music integration right now, so updates are coming out a little bit slowly. I will try to package this with the v1.2.0 release, which should go out within a week or two. |
Added to main: dc82f08 |
Right, I should clarify this behavior. The "Reset Width" button will only appear when there's no room in the menu bar (i.e., when a song is playing and the ear icon is shown). You are welcome to change the prefix length to something larger like 60, of course. I tried not to make it too large in order to be a good "neighbor" to other apps that have a menu bar presence. |
Oh, I'm looking at your original comment in my emails. Yes, I can now see why it would be useful to permanently display an option to reset the width. |
On this I meant that there was persistence with the setting through runs. After I clicked it the first time even after restarting the app/rebuilding it would act as the spotifyViewModel.prefixLength = 45 when I woke the Mac and reduce the size but not change to the ear (I might be going crazy) And on this one:
I was under the impression that even though the length is set to something, if the title is smaller it'll automatically shrink? So when I was playing a song with a short title, when I clicked it, it seemed to shrink? I can get pictures on Monday to clarify what I mean, so I don't think making it large would be unneighbourly |
I'm not entirely sure I understand your comment about persistence--how it works right now is that every time the app starts, the maximum text length is set to 45. If the app detects that it disappeared, it will gradually shrink itself until it either hits zero (ear icon) or appears again. Then it will never expand again until either (1) you use the button I posted, or (2) you restart the app. I'm looking at your image ("I Smoked Away My Brain" song) and it's definitely not 45 characters long. What probably happened is that some external display weirdness caused it to shrink.
As it's implemented now, it should only shrink when there's not enough room. You can make the "Reset Width" button permanently visible by taking it out of the if statement. Right now I am working through a refactor and I plan to permanently have a Reset Width button available just in case. |
Oh, and I will also note that the app always removes everything after the parentheses in the song name. So, |
Version
SoundSeer - v1.1.1
macOS - Sonoma 14.4.1
M1 Chip
Issue
After the Mac goes to sleep, the icon stops updating and becomes an ear. The error shown is:
![image](https://private-user-images.githubusercontent.com/107078260/330846919-14265b71-ebf7-48cb-82bb-312f673550f0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkzNjk1MDgsIm5iZiI6MTcxOTM2OTIwOCwicGF0aCI6Ii8xMDcwNzgyNjAvMzMwODQ2OTE5LTE0MjY1YjcxLWViZjctNDhjYi04MmJiLTMxMmY2NzM1NTBmMC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNjI2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDYyNlQwMjMzMjhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1kMGE5MTA4ZjU2M2ZlMTNkNTk1NWJjYjUwMjExYmJmNzQyMTEyYmIzYjA1NjAzY2Y4Zjg1YzZhYmYyOGNmZjkzJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.iMisCX37l5QQ6EZtAljq5CvBLIgkMx2mP1jxl0qlCG8)
Not enough room for song. Try restarting
But when I restart it shows the song properly. This issue only occurs after the Mac has been sleeping
It is fixed when you restart the app, but since it happens every time the Mac goes to sleep...
The text was updated successfully, but these errors were encountered: