Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bad graph with reverse log #127

Closed
vivien opened this issue Mar 29, 2013 · 3 comments
Closed

bad graph with reverse log #127

vivien opened this issue Mar 29, 2013 · 3 comments
Labels

Comments

@vivien
Copy link
Contributor

vivien commented Mar 29, 2013

tig supports reverse log, but the graph fails:

$ tig --reverse

Maybe graph drawing should be disabled in reverse log?

@benhodgson
Copy link

+1

@BenBergman
Copy link
Contributor

Having just spent a ton of time in the graph functions, I think disabling the graph for --reverse makes sense. The logic essentially draws rows one at a time as needed knowing only about the current commit and the parents of the previous commits that have not yet shown up. Doing this in reverse pretty much means you need to load the entire history and draw it backwards.

git log does not allow the --reverse option to be combined with the --graph option either, so I don't think disabling the reverse graph would be all that bad or unexpected.

@jonas jonas closed this as completed in 5ee77a8 Feb 11, 2014
@jonas
Copy link
Owner

jonas commented Feb 11, 2014

As a nice side effect, Tig's internal option state is now based on arguments passed on the command line (aa6b0e5).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants