Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQ] JIT numeric conversion in mlr put, part 2 of 2 #151

Closed
johnkerl opened this issue Jul 22, 2017 · 4 comments
Closed

[REQ] JIT numeric conversion in mlr put, part 2 of 2 #151

johnkerl opened this issue Jul 22, 2017 · 4 comments
Labels
go-port Things which will be addressed in the Go port AKA Miller 6

Comments

@johnkerl
Copy link
Owner

I'm splitting out this task to separate the put -S workaround part (#150) from a wishlist issue which would go a step further (but at the expense of a significant rewrite):

@gromgit so put -S handles your situation. But your JIT ask is spot-on: we shouldn't have to specify -S if no arithmetic is being done. That's a much larger codemod, and perhaps worth doing ... my uncertainty lies in whether the relative value of JIT-conversion over the FAQ-driven put -S workaround is worth the major rewrite. :^/

@johnkerl
Copy link
Owner Author

This will be addressed by the Go port.

@johnkerl johnkerl added the go-port Things which will be addressed in the Go port AKA Miller 6 label Sep 15, 2020
@johnkerl
Copy link
Owner Author

This is already working in the Go port

@johnkerl
Copy link
Owner Author

Fixed in Miller 6.

@johnkerl
Copy link
Owner Author

More work here on #786.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go-port Things which will be addressed in the Go port AKA Miller 6
Projects
None yet
Development

No branches or pull requests

1 participant