Automatically login an existing account trying to register again. (Features::loginExistingAccountOnRegister)

[DonDiegoAA]

What problem does this feature request solve?.
Avoids displaying an error message to a user trying to register with an existing social account.

Describe your proposed solution
Instead, connect it automatically.
I like the createAccountOnFirstLogin feature.
It would be nice to have the reverse feature loginExistingAccountOnRegister.
Does this cause security issues that I can't see?

Describe alternatives you've considered

Environment context

• Socialstream version: 3.0.2
• Jetstream stack: Livewire
• Laravel version: 8.41.0
• PHP version: 7.4.16

[joelbutcher]

@DonDiegoAA I’ve pushed a branch with a new autoLoginOnRegistration feature. I’m travelling for the weekend to don’t have a lot of time to test this, so feel free to checkout the branch, give it a test yourself and stick any comments in here or PR directly to the branch and I’ll review them when I’m back from my trip.

https://github.com/joelbutcher/socialstream/tree/registration-auto-login

[joelbutcher]

@DonDiegoAA I've created a pull request for the change here #118 as an example of how this could work... I'm still in debate as to whether to actually merge this, based off of the original discussions on Jetstream surrounding auto login on registration, before I wrote this package: laravel/jetstream#444

[mjdigital]

I've just installed this package in a newish project and am getting:

BadMethodCallException
Method JoelButcher\Socialstream\Http\Controllers\OAuthController::login does not exist.

I have had to rework a few areas as I use UUIDs (technically ULIDs) rather than BigInts and split first name/last name for my users but looking at the code in JoelButcher\Socialstream\Http\Controllers\OAuthController.php it appears you have a method called "loginUser" but are calling $this->login($user); throughout the other methods - if I change:

protected function loginUser($user)

to

protected function login($user)

then everything works and the login session is completed successfully.

I'm hoping this is not an issue with my setup and is something that can be fixed in the package but your thoughts would be greatly appreciated.

[joelbutcher]

@mjdigital thanks for spot - Fixed in a patch release v3.1.1

[mjdigital]

@joelbutcher Great thanks, although I may have led you astray a little in my last message by not being specific enough. Although, as I stated, changing ->loginUser() to ->login() worked for me, it was just a quick test and you are still actually calling ->loginUser() on line 209 so either that needs changing to just ->login to match the updated login method or everything needs changing to ->loginUser() (except the actual call on the guard on line 252).

Thanks :)