-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically login an existing account trying to register again. (Features::loginExistingAccountOnRegister) #115
Comments
@DonDiegoAA I’ve pushed a branch with a new https://github.com/joelbutcher/socialstream/tree/registration-auto-login |
@DonDiegoAA I've created a pull request for the change here #118 as an example of how this could work... I'm still in debate as to whether to actually merge this, based off of the original discussions on Jetstream surrounding auto login on registration, before I wrote this package: laravel/jetstream#444 |
I've just installed this package in a newish project and am getting:
I have had to rework a few areas as I use UUIDs (technically ULIDs) rather than BigInts and split first name/last name for my users but looking at the code in JoelButcher\Socialstream\Http\Controllers\OAuthController.php it appears you have a method called "loginUser" but are calling $this->login($user); throughout the other methods - if I change:
to
then everything works and the login session is completed successfully. I'm hoping this is not an issue with my setup and is something that can be fixed in the package but your thoughts would be greatly appreciated. |
@mjdigital thanks for spot - Fixed in a patch release v3.1.1 |
@joelbutcher Great thanks, although I may have led you astray a little in my last message by not being specific enough. Although, as I stated, changing Thanks :) |
What problem does this feature request solve?.
Avoids displaying an error message to a user trying to register with an existing social account.
Describe your proposed solution
Instead, connect it automatically.
I like the createAccountOnFirstLogin feature.
It would be nice to have the reverse feature loginExistingAccountOnRegister.
Does this cause security issues that I can't see?
Describe alternatives you've considered
Environment context
The text was updated successfully, but these errors were encountered: