Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align schemas with names from IFCB v2 header files #29

Open
joefutrelle opened this issue Nov 1, 2016 · 0 comments
Open

align schemas with names from IFCB v2 header files #29

joefutrelle opened this issue Nov 1, 2016 · 0 comments

Comments

@joefutrelle
Copy link
Owner

header files for new-style instruments include a list of ADC columns. It is not expected that the order of ADC columns will change, but possibly new ones will be added. Users may also want to use those column names instead of constant names from the schema classes.

One approach is to use dictlike schema classes keyed by the names in the header files, but this is a problem because the ADC column names could change per-bin, depending on what the instrument manufacturer decides to put in ADC files.

It's possible that bins could inject ADC column names from headers into subclasses of the schema object that they return, but this is a complicated implementation that breaks the idea that schemas can be derived from pids.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant