Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation note about filtering data before passing it to upsetplot.plot #83

Closed
MarvinT opened this issue Nov 12, 2019 · 3 comments

Comments

@MarvinT
Copy link

MarvinT commented Nov 12, 2019

Similar to #81 , I was frustrated that it didn't automatically filter out combinations with small intersection size. It took me way to long to realize I could do it before passing the data to upsetplot.plot. A note in the documentation might help users in the future.

Thanks,
~Marvin

@MarvinT
Copy link
Author

MarvinT commented Nov 12, 2019

Printing a warning if the number of columns is too large might also be a good idea.
You can still try to plot it, but a check in the beginning that says "Warning: you're plotting over 100 columns, you might want to filter your input before trying to plot"

@jnothman
Copy link
Owner

jnothman commented Nov 12, 2019 via email

@MarvinT MarvinT mentioned this issue Nov 13, 2019
@jnothman
Copy link
Owner

min_subset_size has been added, and efficiency for large numbers of subsets has been improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants