-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
memory leak in sql.js, new package needed #53
Comments
I published a new version of @jlongster's fork which contains the fix here: https://www.npmjs.com/package/@aphro/sql.js You can see an example of it in use here: https://aphrodite-examples.pages.dev/todo-mvc/ |
@tantaman can you provide a link to the repo your change was in? I do not see any updates on the last 2 months for the repo's linked. |
oops, looks like I never actually pushed the changes but only published them to npm. Fixed that. I merged the latest Note that these are in the "alt-deploy" branches. "alt-deploy" since the package names are changed for publishing to npm. |
@jlongster It appears that the npm package you have psoed for sql.js does not include the following commit
sql-js/sql.js@ec44c18
We are seeing this memory leak and with large data sets its pretty severe
Your fork does include this commit but the npm package for 1.6.7 looks like it was created Aug 8th which would not have contained this fix
Is it possible to get a new package created? I notice you are attempting to merge you sql.js branch back into the upstream but it hasn't been completed.
The text was updated successfully, but these errors were encountered: