Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory leak in sql.js, new package needed #53

Open
arsnyder16 opened this issue Mar 17, 2022 · 3 comments
Open

memory leak in sql.js, new package needed #53

arsnyder16 opened this issue Mar 17, 2022 · 3 comments

Comments

@arsnyder16
Copy link

arsnyder16 commented Mar 17, 2022

@jlongster It appears that the npm package you have psoed for sql.js does not include the following commit

sql-js/sql.js@ec44c18

We are seeing this memory leak and with large data sets its pretty severe

Your fork does include this commit but the npm package for 1.6.7 looks like it was created Aug 8th which would not have contained this fix

Is it possible to get a new package created? I notice you are attempting to merge you sql.js branch back into the upstream but it hasn't been completed.

@tantaman
Copy link

I published a new version of @jlongster's fork which contains the fix here: https://www.npmjs.com/package/@aphro/sql.js

You can see an example of it in use here: https://aphrodite-examples.pages.dev/todo-mvc/

@twoxfh
Copy link

twoxfh commented Aug 4, 2022

@tantaman can you provide a link to the repo your change was in? I do not see any updates on the last 2 months for the repo's linked.

@tantaman
Copy link

tantaman commented Aug 4, 2022

oops, looks like I never actually pushed the changes but only published them to npm. Fixed that.

I merged the latest sql.js changes in with @jlongster's changes here: https://github.com/tantaman/sql.js/tree/alt-deploy
And updated absurd-sql to use that new sql.js package here: https://github.com/tantaman/absurd-sql/tree/alt-deploy

Note that these are in the "alt-deploy" branches. "alt-deploy" since the package names are changed for publishing to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants