Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Timezone for Datetime Deserializer #747

Closed
simonsolutions opened this issue Jun 26, 2024 · 4 comments
Closed

Wrong Timezone for Datetime Deserializer #747

simonsolutions opened this issue Jun 26, 2024 · 4 comments

Comments

@simonsolutions
Copy link
Contributor

Problem description:

When the library deserialises the DateTimes to DateTime-Objects it uses the local Timezone of the Server. But times ending with Z are UTC timezone. So the DateTime object had the numeric value of the UTC from Amazon but had set the timezone to e.g. Europe/Berlin because of the server default.

@simonsolutions
Copy link
Contributor Author

Proposed fix in PR #746

@simonsolutions
Copy link
Contributor Author

simonsolutions commented Jun 26, 2024

Json Response:
,"FeesEstimate": {
"TimeOfFeesEstimation": "2024-06-26T11:09:40.000Z"

current behaviour:

+timeOfFeesEstimation: DateTime @1719392627 {#3539 ▼
date: 2024-06-26 11:03:47.0 Europe/Berlin (+02:00)
}

@jlevers
Copy link
Owner

jlevers commented Jun 26, 2024

Huh, I'm not seeing this behavior – my dates deserialize into UTC by default:

image

But I guess there isn't any harm in making sure that it's the right timezone...I'll respond to the PR with a couple comments :)

@jlevers
Copy link
Owner

jlevers commented Jul 9, 2024

Fixed in v7.0.4.

@jlevers jlevers closed this as completed Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants