Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganization of classes, Add class Fig LinearFig #183

Open
jjdishere opened this issue Nov 6, 2023 · 1 comment
Open

Reorganization of classes, Add class Fig LinearFig #183

jjdishere opened this issue Nov 6, 2023 · 1 comment

Comments

@jjdishere
Copy link
Owner

There is a problem of DirFig.toDir, it may be not def equal to Ray.toDir otherclass.toDir. Do we need to force they are the same? Is everything ok if we keep this def equal?
Or do we need to bring DirFig into Class.lean then define toDir as early as that? (so there will be no other defs of toDir)

@jjdishere jjdishere changed the title Bring DirFig up earlier, make definition of toDir unique Reorganization of classes, Add class Fig LinearFig Nov 7, 2023
@jjdishere
Copy link
Owner Author

It is possible to reorganize whole class structure.

  1. Fig means have carrier,
  2. Linear means any 3 pts in Carrier is colinear,
  3. DirFig means Fig + has toDir
  4. ProjFig is LinearObj (which cannot extends DirFig, instead Coe DirFig ProjFig, Line is only ProjFig) Maybe ProjFig is exactly Linear?
  5. Intersect should be defined for any 2 Carrier. In Circle files, show it is equiv to r >= d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant