Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variance cutoff used for Noise Injection #14

Open
vinbhaskara opened this issue Jul 3, 2020 · 7 comments
Open

Variance cutoff used for Noise Injection #14

vinbhaskara opened this issue Jul 3, 2020 · 7 comments

Comments

@vinbhaskara
Copy link

vinbhaskara commented Jul 3, 2020

Can you please answer 5 questions because I could not find the details in your paper:

  1. What is the variance cutoff you used for selecting the noise patches
  2. What were the sizes of those noise patches while training (i.e. LR resolution while training).
  3. Do you apply the variance cutoff on the variance of gray scale image or something else?
  4. How many kernels and noise patches did you have in your Pool?
  5. What is the Clean Up scale factor used?

Thanks!

@vinbhaskara
Copy link
Author

@jixiaozhong Could you please respond? These settings were not made clear in the paper for reproducibility purposes.

@yoon28
Copy link

yoon28 commented Jul 15, 2020

Since the paper did not present the parameter settings in detail, I also want to know the secret. In addition to @bsvineethiitg 's five questions, how do you set the initial learning rate and learning rate schedule?

@ALLinLLM
Copy link

I guess they need waiting for the patent, just keep patient

@yoon28
Copy link

yoon28 commented Jul 31, 2020

@bsvineethiitg I implemented the paper unofficially. I saw that noises are very well removed but the sharpness of my results is not comparable to the original results. As you know, reproducing the paper is difficult because the author did not share many of the hyper-parameter settings.
https://github.com/yoon28/realsr-noise-injection

@ALLinLLM
Copy link

ALLinLLM commented Aug 4, 2020

@yoon28 That's true. I implemented the paper using KernelGAN to estimate kernel and create a kernel pool, then using the ESRGAN to train paired images. However, my results is not comparable to the original results too

@qibao77
Copy link

qibao77 commented Oct 27, 2020

@yoon28 That's true. I implemented the paper using KernelGAN to estimate kernel and create a kernel pool, then using the ESRGAN to train paired images. However, my results is not comparable to the original results too

+1

@yoon28
Copy link

yoon28 commented Oct 27, 2020

The author unveiled the training code.
Check this out.
https://github.com/Tencent/Real-SR
After I read the author's implementation, I confirmed that my code was quite close to the author's except for some important hyperparameters.
I appreciate authors to share their codes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants