Better UI Changes #594

creativeblaq · 2021-07-08T20:49:04Z

Made some changes to the User interface both on android and IOS

jhomlala · 2021-07-09T06:02:42Z

Could you explain why did you these changes and what's the purpose of these fixes? Unfortunately, "Better UI" is not enough for me.

creativeblaq · 2021-07-09T10:21:19Z

Could you explain why did you these changes and what's the purpose of these fixes? Unfortunately, "Better UI" is not enough for me.

Simply put no fundamental changes where made to the overall core functionality, only user interface and user experience changes. These are just minor changes to the user controls and how the user interacts with the player.

Changes made

Default player Icons changed
Moved progress bar to the bottom to have more touch space for longer videos
This leaves the ui having a more stacked view and breathability

Modal dialog switches from the default material modal on android and cupertino popup modal on ios
Added some rounded edges for taste
Selected modal item has a check icon to clearly identify the user choice

Planning on adding more interface features like double tap to skip and allowing the user to choose whether they want a stacked ui or a more linear.

* Fixed play after seeking issue on iOS * Fixed audio track selection issue on iOS/Android * Fixed issue where speed which couldn't be applied on iOS was saved in player state. * Added support for D-pad navigation using a Android TV remote control (jhomlala#586) * Exposes all active eventListener (jhomlala#585) * Updated changelog * Added docs * Updated documentation * Updated documentation * Added BetterPlayerMultipleGestureDetector, general refactor * General refactor Co-authored-by: Daniel Zarins <[email protected]> Co-authored-by: Letalus <[email protected]>

sha3rawi33 · 2021-07-17T07:21:50Z

@creativeblaq That's really nice work. when can you implement the double tab seek? I'm waiting for it 💯
good luck

kabirnayeem99 · 2021-07-17T15:29:31Z

Wow. This looks sick. Loving this so far. Client asked for exactly the same changes a few months ago. And the current controls, honestly, looks kind of ugly. Waiting to see these changes merged into the main branch.

kabirnayeem99 · 2021-07-17T15:31:34Z

example/lib/pages/playlist_page.dart

@@ -30,7 +30,7 @@ class _PlaylistPageState extends State<PlaylistPage> {
 );
 _betterPlayerPlaylistConfiguration = BetterPlayerPlaylistConfiguration(
 loopVideos: true,
- nextVideoDelay: Duration(seconds: 1),
+ nextVideoDelay: Duration(seconds: 3),


I thought the change were only related to the UI.

To me this did seem like a ui component since there is a display component that tells the user how long till the next video.
If 3 seconds is a lot this is honestly one line of code that can easily be modified.

kabirnayeem99 · 2021-07-17T15:32:10Z

lib/src/configuration/better_player_controls_configuration.dart

- this.forwardSkipTimeInMilliseconds = 15000,
- this.backwardSkipTimeInMilliseconds = 15000,
+ this.forwardSkipTimeInMilliseconds = 10000,
+ this.backwardSkipTimeInMilliseconds = 10000,


This is also changes unrelated to UI.

This has actually changed based on the ui change. The default icon for skipping forward or back says your skipping at a rate of 10 seconds, this however is still modifiable when constructing the player controls configurations instance.

kabirnayeem99

There are some changes that are unrelated to the UI, such as,

Change in the delay time in 'nextVideoPlay' have been changed from 1 to 3 seconds.
forwardSkipTimeInMilliseconds has also been changed from 15000 to 10000.

creativeblaq · 2021-07-18T20:56:30Z

There are some changes that are unrelated to the UK, such as,

Change in the delay time in 'nextVideoPlay' have been changed from 1 to 3 seconds.

forwardSkipTimeInMilliseconds has also been changed from 15000 to 10000.

I am assuming you meant the UI, but I did mention that the changes I made focused both on UI and UX (User interface and User experience), I'm not sure you are aware that these times can be changed when creating the player controls configuration instance in the code and can be passed through as parameters there to tailor them to your needs.

creativeblaq · 2021-07-18T20:58:05Z

@creativeblaq That's really nice work. when can you implement the double tab seek? I'm waiting for it 💯
good luck

I will get to it as soon as possible. I am glad you approve of the changes.

kabirnayeem99 · 2021-07-19T07:22:27Z

I am aware of this, sir. Not to mention that, I love this new design. I have just mentioned those changes to clarify. Thank your for your kind reply.

jhomlala · 2021-08-15T16:13:30Z

Awesome work. LGTM!

* Added licenseUrl support for iOS DRM. * Fixed RTL text direction issue in player controls. * Updated normal player page * Added currently displayed subtitle * Added additional check in `postControllerEvent` to handle scenario where event stream is closed. * Updated ExoPlayer version * Buffering fix in Android, video list update * * Added `setMixWithOthers` method in `BetterPlayerListVideoPlayerController`. * Fixed broken ling in cover page of documentatio * Fixed progress bar issue where position could be set above video duration * Fixed iOS remote notification command issu * Update welcome_page.dart (#607) Removed duplicated page * Removed duplicated page in example app (by https://github.com/pinguluk) * Added support for ClearKey DRM for File Datasource. (#566) * Added support for ClearKey DRM for File Datasource. * Formatting of ClearKey implementation code. * Added ClearKey support for BetterPlayerDataSourceType.network and BetterPlayerDataSourceType.memory for Android. * Added ClearKey DRM to new documentation format. * Clear key DRM update * Better UI Changes (#594) * Better UI Changes * Update ci.yml * Feature/july changes (#598) * Fixed play after seeking issue on iOS * Fixed audio track selection issue on iOS/Android * Fixed issue where speed which couldn't be applied on iOS was saved in player state. * Added support for D-pad navigation using a Android TV remote control (#586) * Exposes all active eventListener (#585) * Updated changelog * Added docs * Updated documentation * Updated documentation * Added BetterPlayerMultipleGestureDetector, general refactor * General refactor Co-authored-by: Daniel Zarins <[email protected]> Co-authored-by: Letalus <[email protected]> * Updated docs * Updated docs * Updated docs * Updated docs * fixed conflicts * Duplicated named argument 'onLongPress' removed * Better UI Changes * Feature/july changes (#598) * Fixed play after seeking issue on iOS * Fixed audio track selection issue on iOS/Android * Fixed issue where speed which couldn't be applied on iOS was saved in player state. * Added support for D-pad navigation using a Android TV remote control (#586) * Exposes all active eventListener (#585) * Updated changelog * Added docs * Updated documentation * Updated documentation * Added BetterPlayerMultipleGestureDetector, general refactor * General refactor Co-authored-by: Daniel Zarins <[email protected]> Co-authored-by: Letalus <[email protected]> * fixed conflicts Co-authored-by: Jakub <[email protected]> Co-authored-by: Daniel Zarins <[email protected]> Co-authored-by: Letalus <[email protected]> * Updated changelog * Added `sigmaX` and `sigmaY` parameters in BetterPlayerControlsConfiguration * Updated lint and format * Updated versions Co-authored-by: Pinguluk <[email protected]> Co-authored-by: tinusneethling <[email protected]> Co-authored-by: creativeblaq <[email protected]> Co-authored-by: Daniel Zarins <[email protected]> Co-authored-by: Letalus <[email protected]>

Supriyanto6543 · 2022-08-02T03:07:31Z

When you add new features about next and previous video sir? I am waiting it.
@jhomlala

* Added licenseUrl support for iOS DRM. * Fixed RTL text direction issue in player controls. * Updated normal player page * Added currently displayed subtitle * Added additional check in `postControllerEvent` to handle scenario where event stream is closed. * Updated ExoPlayer version * Buffering fix in Android, video list update * * Added `setMixWithOthers` method in `BetterPlayerListVideoPlayerController`. * Fixed broken ling in cover page of documentatio * Fixed progress bar issue where position could be set above video duration * Fixed iOS remote notification command issu * Update welcome_page.dart (jhomlala#607) Removed duplicated page * Removed duplicated page in example app (by https://github.com/pinguluk) * Added support for ClearKey DRM for File Datasource. (jhomlala#566) * Added support for ClearKey DRM for File Datasource. * Formatting of ClearKey implementation code. * Added ClearKey support for BetterPlayerDataSourceType.network and BetterPlayerDataSourceType.memory for Android. * Added ClearKey DRM to new documentation format. * Clear key DRM update * Better UI Changes (jhomlala#594) * Better UI Changes * Update ci.yml * Feature/july changes (jhomlala#598) * Fixed play after seeking issue on iOS * Fixed audio track selection issue on iOS/Android * Fixed issue where speed which couldn't be applied on iOS was saved in player state. * Added support for D-pad navigation using a Android TV remote control (jhomlala#586) * Exposes all active eventListener (jhomlala#585) * Updated changelog * Added docs * Updated documentation * Updated documentation * Added BetterPlayerMultipleGestureDetector, general refactor * General refactor Co-authored-by: Daniel Zarins <[email protected]> Co-authored-by: Letalus <[email protected]> * Updated docs * Updated docs * Updated docs * Updated docs * fixed conflicts * Duplicated named argument 'onLongPress' removed * Better UI Changes * Feature/july changes (jhomlala#598) * Fixed play after seeking issue on iOS * Fixed audio track selection issue on iOS/Android * Fixed issue where speed which couldn't be applied on iOS was saved in player state. * Added support for D-pad navigation using a Android TV remote control (jhomlala#586) * Exposes all active eventListener (jhomlala#585) * Updated changelog * Added docs * Updated documentation * Updated documentation * Added BetterPlayerMultipleGestureDetector, general refactor * General refactor Co-authored-by: Daniel Zarins <[email protected]> Co-authored-by: Letalus <[email protected]> * fixed conflicts Co-authored-by: Jakub <[email protected]> Co-authored-by: Daniel Zarins <[email protected]> Co-authored-by: Letalus <[email protected]> * Updated changelog * Added `sigmaX` and `sigmaY` parameters in BetterPlayerControlsConfiguration * Updated lint and format * Updated versions Co-authored-by: Pinguluk <[email protected]> Co-authored-by: tinusneethling <[email protected]> Co-authored-by: creativeblaq <[email protected]> Co-authored-by: Daniel Zarins <[email protected]> Co-authored-by: Letalus <[email protected]>

Better UI Changes

cc5dd1f

jhomlala and others added 14 commits July 9, 2021 12:43

Update ci.yml

7447be4

Updated docs

73a75e4

Updated docs

8199140

Updated docs

bf87166

Updated docs

82da9c6

fixed conflicts

582199c

Merge branch 'master' into master

18c794f

Duplicated named argument 'onLongPress' removed

18d427d

Merge branch 'jhomlala:master' into master

6fb2b62

Better UI Changes

a1354eb

fixed conflicts

3f7a9e4

Merge remote-tracking branch 'origin/master'

cb7996b

saravut123 approved these changes Jul 13, 2021

View reviewed changes

kabirnayeem99 reviewed Jul 17, 2021

View reviewed changes

jhomlala changed the base branch from master to feature/august_changes August 15, 2021 16:13

jhomlala merged commit c55358e into jhomlala:feature/august_changes Aug 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Better UI Changes #594

Better UI Changes #594

creativeblaq commented Jul 8, 2021

jhomlala commented Jul 9, 2021

creativeblaq commented Jul 9, 2021

sha3rawi33 commented Jul 17, 2021 •

edited

Loading

kabirnayeem99 commented Jul 17, 2021

kabirnayeem99 Jul 17, 2021

creativeblaq Jul 18, 2021

kabirnayeem99 Jul 17, 2021

creativeblaq Jul 18, 2021

kabirnayeem99 left a comment •

edited

Loading

creativeblaq commented Jul 18, 2021

creativeblaq commented Jul 18, 2021

kabirnayeem99 commented Jul 19, 2021

jhomlala commented Aug 15, 2021

Supriyanto6543 commented Aug 2, 2022

Better UI Changes #594

Better UI Changes #594

Conversation

creativeblaq commented Jul 8, 2021

jhomlala commented Jul 9, 2021

creativeblaq commented Jul 9, 2021

sha3rawi33 commented Jul 17, 2021 • edited Loading

kabirnayeem99 commented Jul 17, 2021

kabirnayeem99 Jul 17, 2021

Choose a reason for hiding this comment

creativeblaq Jul 18, 2021

Choose a reason for hiding this comment

kabirnayeem99 Jul 17, 2021

Choose a reason for hiding this comment

creativeblaq Jul 18, 2021

Choose a reason for hiding this comment

kabirnayeem99 left a comment • edited Loading

Choose a reason for hiding this comment

creativeblaq commented Jul 18, 2021

creativeblaq commented Jul 18, 2021

kabirnayeem99 commented Jul 19, 2021

jhomlala commented Aug 15, 2021

Supriyanto6543 commented Aug 2, 2022

sha3rawi33 commented Jul 17, 2021 •

edited

Loading

kabirnayeem99 left a comment •

edited

Loading