Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Antonio Carbajal missing on Player_Appearences table #4

Closed
glasneed opened this issue Dec 16, 2022 · 2 comments
Closed

Antonio Carbajal missing on Player_Appearences table #4

glasneed opened this issue Dec 16, 2022 · 2 comments

Comments

@glasneed
Copy link

glasneed commented Dec 16, 2022

Hi,
I noticed that Mexican goalkeeper, Antonio Carbajal, is missing on the player_appearences table. He is on the players table and shows that he played in 5 tournaments which is correct.

https://www.thesoccerworldcups.com/players/antonio_carbajal.php

SELECT player_id, position_name FROM player_appearances where player_id IN (SELECT player_ID from players where family_name = 'Carbajal')

@jfjelstul
Copy link
Owner

Thanks for using the data!

player_appearances starts in 1970 and Carbajal's last tournament was 1966, so that's why he doesn't appear. But he does appear in squads, which goes back to 1930. That's why list_tournaments in players is still correct.

I'll look into collecting earlier data. The problem is that player_appearances includes starters and subs, and information on subs isn't consistently available before 1970.

@glasneed
Copy link
Author

Thank you for the clarification. I guess I should have read the first line in the code book for player appearances.
It came up because I was solving a challenge for 'players for the most tournaments played'. I found this table to be the best source because, for example, Gianluigi Buffon played in 4 tournaments but 'attended' 5. When I relied on this table and didn't return Antonio Carbajal, I opened the ticket.
Fantastic dataset BTW!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants