Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Repo with player appearances and bookings from 1930 to 1966 #3

Open
samueleleli opened this issue Dec 4, 2022 · 5 comments
Open
Labels
enhancement New feature or request

Comments

@samueleleli
Copy link

samueleleli commented Dec 4, 2022

Hi @jfjelstul

First, thank you for this repo!

This is not an issue. I'm contacting you because I have updated csv data of player appearences and bookings from 1930 to 1966. If you are interested I can send them to you privately so that you can watch them and can update the repository.

Kind regards, Samuele

@MarcelvanVuuren
Copy link

MarcelvanVuuren commented Dec 19, 2022

@samueleleli,

I'm interested in the data. If you want to share it with me I will be pleased.

Thanks, Marcel

@samueleleli
Copy link
Author

Hi @MarcelvanVuuren,

Here you are the data

bookings.csv
player_appearances.csv

@MarcelvanVuuren
Copy link

Hi @MarcelvanVuuren,

Here you are the data

bookings.csv player_appearances.csv

Thanks

@jfjelstul
Copy link
Owner

Thanks @samueleleli for letting me know about this data on bookings and player appearances. What's the source and license?

@samueleleli
Copy link
Author

Hi @jfjelstul,

I got the source from your github and we edited them manually, going to fifa.com to check for each match (we did not use external APIs).

Kind regards, Samuele

@jfjelstul jfjelstul added the enhancement New feature or request label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants