Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jetify-com/devbox-install-action Loading
base: v0.5.0
Choose a base ref
...
head repository: jetify-com/devbox-install-action Loading
compare: v0.7.0
Choose a head ref
  • 11 commits
  • 4 files changed
  • 4 contributors

Commits on Jul 27, 2023

  1. Update README.md

    Signed-off-by: Lucille Hua <[email protected]>
    LucilleH committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    1be8e96 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. Configuration menu
    Copy the full SHA
    a739e51 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Update README.md

    Signed-off-by: Lucille Hua <[email protected]>
    LucilleH committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    5798c46 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. Ensure nix is installed (#16)

    Temporary fix until jetify-com/devbox#1453 is
    released
    mikeland73 committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    a0bd99f View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. Fix macos caching issue (#19)

    ### Description
    macOS caching is broken. This PR fixes it. This is related to `gtar` not
    having `sudo` permission, but `/nix/store` requires sudo. There are many
    many related issues out there. eg.
    actions/cache#749
    
    I also switched to using DeterminateSystems nix installer. However, I
    noticed that even though cache is successfully restored in the latest
    round of CICD, we are still fetching the binaries from remote? (at least
    based on the log lines) Why is that?
    
    I suspect that I'm missing some sqlite data in the cached files. cc
    @savil @gcurtis if any of you have insights into this.
    
    EDIT: SOLVED. Added xdg paths in the cache and it reduces the time by
    half. 🎉 🎉 🎉
    
    closes #13
    LucilleH committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    572189b View commit details
    Browse the repository at this point in the history
  2. Update README.md

    Signed-off-by: Lucille Hua <[email protected]>
    LucilleH committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    1998394 View commit details
    Browse the repository at this point in the history
  3. Narrow the cache of xdg directory (#20)

    Narrow the cache of xdg directory per request from @savil
    LucilleH committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    76d8a64 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. Revert "Narrow the cache of xdg directory" (#22)

    Reverts #20
    
    This results in the `~/.cache` directory gets created under `root`
    instead of `runner`. Reverting fix this problem.
    
    Verified the fix with
    #21
    LucilleH committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    c1d7077 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. Restores the tar command to its original state (#21)

    ### What
    This PR tries to reduce side effects by:
    - Restores the `tar` command to its original state
    - Narrow the ~/.cache directory to just nix and devbox
    
    ### Why
    We are using `chmod u+s "$(command -v tar)"` to setuid on tar (This is
    needed because we are caching `/nix/` and other directories outside of
    `~`, which is owned by `root`)
    
    This has a problem where it changes the parent directory of
    `~/.cache/nix` to be owned by `root` instead of `runner`.
    
    I thought #22
    had fixed it, but we ran into similar issues when we use a go cache on
    top of the devbox cache.
    
    ### Caveat
    Cache enabled on self hosted Linux may stop working
    LucilleH committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    f013611 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. feat: skip-nix-install (#23)

    We have some problems in our custom runner with this action so I've
    tried it with skipping the installation via the included action and it
    works in our runners (we do not use the GitHub provided ones, we are
    using custom runners).
    
    In case you are wondering which action we are using, we use:
    `cachix/install-nix-action@v23` - I guess it has something to do with
    the usage of `sudo` in the other action but I'm not 100% sure on that.
    I'm also not sure about the differences between these two actions so
    I've opted for the possibility to skip the installation rather than
    changing the action as I guess you've put a lot of thought into which
    action to use.
    
    Edit: I need to correct myself, it's not because of `sudo` but because
    of `systemd`. I tried to run the action without `systemd` by passing in
    `init: none` and `planner: linux-multi` but I got other errors. So I
    would prefer to be able to just skip the installation and use my own / a
    different action to install `nix`.
    mstruebing committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    6b09349 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. Replace github cache action with restore and save (#24)

    ### What
    Instead of letting `action/cache` do the restoring and saving cache for
    us, we choose when to restore and when to save cache.
    
    In this case, we will be saving cache immediately after the devbox
    package installation, instead of waiting for the action post run. This
    way, the `tar` sudo permission stays intact until the cache is saved.
    
    More specifically, `action/cache/save` runs before the last step of
    restoring `tar` to its original permission (as oppose to after)
    LucilleH committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    e523b1c View commit details
    Browse the repository at this point in the history
Loading