Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rule disallowing importing jest #90

Closed
SimenB opened this issue Feb 25, 2018 · 2 comments
Closed

Add rule disallowing importing jest #90

SimenB opened this issue Feb 25, 2018 · 2 comments
Labels
good first issue help wanted new rule

Comments

@SimenB
Copy link
Member

SimenB commented Feb 25, 2018

See jestjs/jest#4613, this is apparently a footgun.

We might take it one step further an yell at all assignments to a jest object as it might mess up static analysis, thus negating hoisting of jest.mock?

But at least a rule for not importing jest (as it doesn't export anything) makes sense.
@brianlmacdonald
Copy link
Contributor

@SimenB can I take this one?

@SimenB
Copy link
Member Author

SimenB commented Feb 28, 2018

Go for it! 🙂

@brianlmacdonald brianlmacdonald mentioned this issue Mar 2, 2018
Merged
@SimenB SimenB closed this as completed in #95 Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted new rule
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SimenB @brianlmacdonald