-
Notifications
You must be signed in to change notification settings - Fork 228
/
no-if.ts
121 lines (110 loc) · 2.94 KB
/
no-if.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
import { AST_NODE_TYPES, type TSESTree } from '@typescript-eslint/utils';
import {
TestCaseName,
createRule,
getAccessorValue,
getDeclaredVariables,
getNodeName,
getTestCallExpressionsFromDeclaredVariables,
parseJestFnCall,
} from './utils';
const testCaseNames = new Set<string | null>([
...Object.keys(TestCaseName),
'it.only',
'it.only',
'it.skip',
'it.skip',
'test.only',
'test.only',
'test.skip',
'test.skip',
'fit.concurrent',
]);
const isTestFunctionExpression = (
node: TSESTree.ArrowFunctionExpression | TSESTree.FunctionExpression,
) =>
node.parent !== undefined &&
node.parent.type === AST_NODE_TYPES.CallExpression &&
testCaseNames.has(getNodeName(node.parent.callee));
const conditionName = {
[AST_NODE_TYPES.ConditionalExpression]: 'conditional',
[AST_NODE_TYPES.SwitchStatement]: 'switch',
[AST_NODE_TYPES.IfStatement]: 'if',
};
export default createRule({
name: __filename,
meta: {
docs: {
description: 'Disallow conditional logic',
category: 'Best Practices',
recommended: false,
},
messages: {
conditionalInTest: 'Test should not contain {{ condition }} statements',
},
deprecated: true,
replacedBy: ['no-conditional-in-test'],
schema: [],
type: 'suggestion',
},
defaultOptions: [],
create(context) {
const stack: boolean[] = [];
function validate(
node:
| TSESTree.ConditionalExpression
| TSESTree.SwitchStatement
| TSESTree.IfStatement,
) {
const lastElementInStack = stack[stack.length - 1];
if (stack.length === 0 || !lastElementInStack) {
return;
}
context.report({
data: { condition: conditionName[node.type] },
messageId: 'conditionalInTest',
node,
});
}
return {
CallExpression(node) {
const jestFnCall = parseJestFnCall(node, context);
if (jestFnCall?.type === 'test') {
stack.push(true);
if (jestFnCall.members.some(s => getAccessorValue(s) === 'each')) {
stack.push(true);
}
}
},
FunctionExpression(node) {
stack.push(isTestFunctionExpression(node));
},
FunctionDeclaration(node) {
const declaredVariables = getDeclaredVariables(context, node);
const testCallExpressions = getTestCallExpressionsFromDeclaredVariables(
declaredVariables,
context,
);
stack.push(testCallExpressions.length > 0);
},
ArrowFunctionExpression(node) {
stack.push(isTestFunctionExpression(node));
},
IfStatement: validate,
SwitchStatement: validate,
ConditionalExpression: validate,
'CallExpression:exit'() {
stack.pop();
},
'FunctionExpression:exit'() {
stack.pop();
},
'FunctionDeclaration:exit'() {
stack.pop();
},
'ArrowFunctionExpression:exit'() {
stack.pop();
},
};
},
});