-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add i18n for Command Log #2848
Labels
Comments
jesseduffield
added
enhancement
New feature or request
good first issue
Good for newcomers
labels
Jul 30, 2023
6 tasks
I want to do this one. Any thoughts on how to test it? Or it is not necessary: just move the code from hard coded to i18n file |
Sounds good @KarlHeitmann ! No need to worry about tests, I consider this copy stuff low-stakes |
6 tasks
I think this issue can be closed -- it has been resolved by #2852 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We need to internationalise the strings we pass to the LogCommand function. Due to an oversight, these are all hard-coded at the moment:
Here's an example of i18n'ing one of the instances:
The text was updated successfully, but these errors were encountered: