-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Comparing changes
Open a pull request
base repository: prometheus/node_exporter
base: master
head repository: jelmd/node_exporter
compare: main
- 19 commits
- 1,369 files changed
- 2 contributors
Commits on Dec 4, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 6849ccb - Browse repository at this point
Copy the full SHA 6849ccbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 16bb097 - Browse repository at this point
Copy the full SHA 16bb097View commit details -
set default make target to build
Stuff run by target 'all' is usually not needed and a lot of overhead. So if one wants to make all he should call 'make all' explicitly.
Configuration menu - View commit details
-
Copy full SHA for b67a004 - Browse repository at this point
Copy the full SHA b67a004View commit details -
Is absolutely useless to include any VCS specific version strings or UUIDs into a version stirng: it makes it hard to normal people to read and if built from a different repo they do not match anyway. And if the VCS changes, all the bloat for nothing. People should have learned this lesson a long time ago. What matters only is the release tag: [0-9]+.[0-9]+.[0-9]+(.[0-9]+)*
Configuration menu - View commit details
-
Copy full SHA for f47a935 - Browse repository at this point
Copy the full SHA f47a935View commit details -
measure the overall scrapetime as well
We need to know, how long scraping all target takes. Since it may happen in parallel adding scrapetimes of all targets is misleading. E.g.: node_scrape_collector_duration_seconds{collector="overall"}
Configuration menu - View commit details
-
Copy full SHA for 075564c - Browse repository at this point
Copy the full SHA 075564cView commit details
Commits on Dec 6, 2021
-
new feature: --web.disable-go-metrics
Certain aspects of the running node-exporter are in a day-by-day scenario interesting (like process metrics), but certainly not the go metrics - non-developers often don't even know, what they mean. So admins should be able to turn off this bloat but still have the process metrics.
Configuration menu - View commit details
-
Copy full SHA for 6fc163d - Browse repository at this point
Copy the full SHA 6fc163dView commit details -
HELP and TYPE comments are usually useless for DBs as wel as utilities processing timeseries. So there is a lot (~ 50% sometimes even more) of overhead sent over the wire without any needs. Producing and processing this bloat needs additional ressources. So allow to run it e.g. in production environments in an efficient way and skip sending this info.
Configuration menu - View commit details
-
Copy full SHA for 1d24e6b - Browse repository at this point
Copy the full SHA 1d24e6bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e157af - Browse repository at this point
Copy the full SHA 8e157afView commit details -
new feature: --collector.cpu.stats --collector.cpu.throttle + cleanup
The cpu_linux collector collects several CPU related metrics, which have little use in a day-by-day scenario (but might be useful from time to time when troubleshoutinh problems). So people may now use --no-collector.cpu.stats and --no-collector.cpu.throttle to disable collecting/emitting such metrics. Furthermore /proc/cpuinfo duplicates the CPU package infos for each strand - for many core systems a huge amount of useless data. So linux cpuinfo collector got modified to collect CPU info for each CPU package, only. In addition /proc/cpuinfo now gets collected only once, when the collector instance gets created. If one adds/removes a CPU package on the fly, which is very unlikeley, one needs to restart the collector to reflect the system changes. Last but not least useless bloat gets removed from model_name and min, max and base frequency provided in a separate label entry.
Configuration menu - View commit details
-
Copy full SHA for 2041c15 - Browse repository at this point
Copy the full SHA 2041c15View commit details -
PSI collector linux: cleanup, de-obfuscated and optimized
Admins need a clear understanding, what values are provided and where they come from. Therefore metrics got renamed from 'pressure' to 'psi' (to avoid confusion, too), and labels use the same names as in related pressure files. Misleading/vague HELP msgs got corrected, now match the official documentation. Last but not least no more useless value convertion from µs to s (there is no need at all for it and pure overhead) and the last value of any line gets parsed, only (all others ignored because dropped anyway).
Configuration menu - View commit details
-
Copy full SHA for 79b2c57 - Browse repository at this point
Copy the full SHA 79b2c57View commit details -
Configuration menu - View commit details
-
Copy full SHA for 03704bd - Browse repository at this point
Copy the full SHA 03704bdView commit details -
nfs[d] collector for linux: consolidation + NFSv4+ support
Cleanup, bugfixes and consolidation of the linux nfs[d] collectors. Still a bit messy, and questionable designed (also wrt. performance), but one step after the other ... ;-) Obsolete stat data neither get parsed nor "0" metrics emitted for them anymore. NFSv4.0 ops got fixed and 4.1 + 4.2 incl. RFC 8276 op support added. NFS4 metrics with no data get neither constructed nor sent (e.g. for NFS4.0 box server and client metrics for NFSv4.1 and NFS.4.2 are skipped). Metrics and related labels got renamed to something what makes sense to an admin and better reflects its purpose.
Configuration menu - View commit details
-
Copy full SHA for 14203f8 - Browse repository at this point
Copy the full SHA 14203f8View commit details -
new feature: --collector.nfsd.skip=list
Skip parsing data and sending nfsd metrics for the given list of NFS versions. list is a comma separated list of 2, 3, 4, or 4ops. E.g. --collector.nfsd.skip=2,4ops
Jens Elkner committedDec 6, 2021 Configuration menu - View commit details
-
Copy full SHA for fc8184a - Browse repository at this point
Copy the full SHA fc8184aView commit details -
rename binary to node-exporter
Underlines are at least for german users a pain because it needs an extra key to be pressed. So replace '_' with '-' in the binary name.
Jens Elkner committedDec 6, 2021 Configuration menu - View commit details
-
Copy full SHA for 1feb51d - Browse repository at this point
Copy the full SHA 1feb51dView commit details -
Get the total number of CPU cores (or strands if HT or SMT is enabled) which are online or offline. Uses syconf to get the required data.
Jens Elkner committedDec 6, 2021 Configuration menu - View commit details
-
Copy full SHA for afa9f7d - Browse repository at this point
Copy the full SHA afa9f7dView commit details -
new feature: /proc/fs/nfsd/pool_stats metrics for Linux
If you have NFSd performance problems on Linux, you should 1st look at these node_nfsd_thread_status metrics - that's basically what really matters (you probably can't do much wrt. NFS ops executed). If (enqueued - woken) alias deferred or timedout increaseses considerably, you probably need to rise the number of knfsd threads handling the workload ;-).
Jens Elkner committedDec 6, 2021 Configuration menu - View commit details
-
Copy full SHA for 920b3ae - Browse repository at this point
Copy the full SHA 920b3aeView commit details
Commits on Dec 17, 2021
-
Sync with 'upstream/master' (2021-12-17 749b1a1)
Jens Elkner committedDec 17, 2021 Configuration menu - View commit details
-
Copy full SHA for 423d7eb - Browse repository at this point
Copy the full SHA 423d7ebView commit details -
Jens Elkner committed
Dec 17, 2021 Configuration menu - View commit details
-
Copy full SHA for c156427 - Browse repository at this point
Copy the full SHA c156427View commit details
Commits on Dec 19, 2021
-
Jens Elkner committed
Dec 19, 2021 Configuration menu - View commit details
-
Copy full SHA for 9ff9cd8 - Browse repository at this point
Copy the full SHA 9ff9cd8View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...main