Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: prometheus/node_exporter Loading
base: master
Choose a base ref
...
head repository: jelmd/node_exporter Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 19 commits
  • 1,369 files changed
  • 2 contributors

Commits on Dec 4, 2021

  1. Configuration menu
    Copy the full SHA
    6849ccb View commit details
    Browse the repository at this point in the history
  2. track vendor files as well

    jelmd committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    16bb097 View commit details
    Browse the repository at this point in the history
  3. set default make target to build

    Stuff run by target 'all' is usually not needed and a lot of overhead.
    So if one wants to make all he should call 'make all' explicitly.
    jelmd committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    b67a004 View commit details
    Browse the repository at this point in the history
  4. simplify Version string

    Is absolutely useless to include any VCS specific version strings
    or UUIDs into a version stirng: it makes it hard to normal people
    to read and if built from a different repo they do not match anyway.
    And if the VCS changes, all the bloat for nothing. People should
    have learned this lesson a long time ago. What matters only is the
    release tag: [0-9]+.[0-9]+.[0-9]+(.[0-9]+)*
    jelmd committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    f47a935 View commit details
    Browse the repository at this point in the history
  5. measure the overall scrapetime as well

    We need to know, how long scraping all target takes. Since it may
    happen in parallel adding scrapetimes of all targets is misleading.
    E.g.: node_scrape_collector_duration_seconds{collector="overall"}
    jelmd committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    075564c View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2021

  1. new feature: --web.disable-go-metrics

    Certain aspects of the running node-exporter are in a day-by-day
    scenario interesting (like process metrics), but certainly not
    the go metrics - non-developers often don't even know, what they
    mean. So admins should be able to turn off this bloat but still
    have the process metrics.
    jelmd authored and Jens Elkner committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    6fc163d View commit details
    Browse the repository at this point in the history
  2. new feature: --compact

    HELP and TYPE comments are usually useless for DBs as wel as utilities
    processing timeseries. So there is a lot (~ 50% sometimes even more) of
    overhead sent over the wire without any needs. Producing and processing
    this bloat needs additional ressources. So allow to run it e.g. in
    production environments in an efficient way and skip sending this info.
    jelmd authored and Jens Elkner committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    1d24e6b View commit details
    Browse the repository at this point in the history
  3. reduce the rediculouse long dmi HELP msg to what is needed

    jelmd authored and Jens Elkner committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    8e157af View commit details
    Browse the repository at this point in the history
  4. new feature: --collector.cpu.stats --collector.cpu.throttle + cleanup

    The cpu_linux collector collects several CPU related metrics, which
    have little use in a day-by-day scenario (but might be useful from
    time to time when troubleshoutinh problems). So people may now use
    --no-collector.cpu.stats and --no-collector.cpu.throttle to disable
    collecting/emitting such metrics.
    
    Furthermore /proc/cpuinfo duplicates the CPU package infos for each
    strand - for many core systems a huge amount of useless data. So
    linux cpuinfo collector got modified to collect CPU info for each
    CPU package, only.
    
    In addition /proc/cpuinfo now gets collected only once, when the
    collector instance gets created. If one adds/removes a CPU package
    on the fly, which is very unlikeley, one needs to restart the collector
    to reflect the system changes.
    
    Last but not least useless bloat gets removed from model_name and
    min, max and base frequency provided in a separate label entry.
    jelmd authored and Jens Elkner committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    2041c15 View commit details
    Browse the repository at this point in the history
  5. PSI collector linux: cleanup, de-obfuscated and optimized

    Admins need a clear understanding, what values are provided and
    where they come from. Therefore metrics got renamed from 'pressure'
    to 'psi' (to avoid confusion, too), and labels use the same names
    as in related pressure files.
    
    Misleading/vague HELP msgs got corrected, now match the official
    documentation.
    
    Last but not least no more useless value convertion from µs to s
    (there is no need  at all for it and pure overhead) and the last
    value of any line gets parsed, only (all others ignored because
    dropped anyway).
    jelmd authored and Jens Elkner committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    79b2c57 View commit details
    Browse the repository at this point in the history
  6. ParseUint64s(): Allow to specify the min size of the returned slice

    jelmd authored and Jens Elkner committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    03704bd View commit details
    Browse the repository at this point in the history
  7. nfs[d] collector for linux: consolidation + NFSv4+ support

    Cleanup, bugfixes and consolidation of the linux nfs[d] collectors.
    Still a bit messy, and questionable designed (also wrt. performance),
    but one step after the other ... ;-)
    
    Obsolete stat data neither get parsed nor "0" metrics emitted for
    them anymore.
    
    NFSv4.0 ops got fixed and 4.1 + 4.2 incl. RFC 8276 op support added.
    
    NFS4 metrics with no data get neither constructed nor sent (e.g.
    for NFS4.0 box server and client metrics for NFSv4.1 and NFS.4.2
    are skipped).
    
    Metrics and related labels got renamed to something what makes sense
    to an admin and better reflects its purpose.
    jelmd authored and Jens Elkner committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    14203f8 View commit details
    Browse the repository at this point in the history
  8. new feature: --collector.nfsd.skip=list

    Skip parsing data and sending nfsd metrics for the given list of
    NFS versions.  list is a comma separated list of 2, 3, 4, or 4ops.
    E.g. --collector.nfsd.skip=2,4ops
    Jens Elkner committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    fc8184a View commit details
    Browse the repository at this point in the history
  9. rename binary to node-exporter

    Underlines are at least for german users a pain because it needs an
    extra key to be pressed. So replace '_' with '-' in the binary name.
    Jens Elkner committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    1feb51d View commit details
    Browse the repository at this point in the history
  10. new feature: --collector.cpus

    Get the total number of CPU cores (or strands if HT or SMT is
    enabled) which are online or offline. Uses syconf to get the
    required data.
    Jens Elkner committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    afa9f7d View commit details
    Browse the repository at this point in the history
  11. new feature: /proc/fs/nfsd/pool_stats metrics for Linux

    If you have NFSd performance problems on Linux, you should 1st look
    at these node_nfsd_thread_status metrics - that's basically what
    really matters (you probably can't do much wrt. NFS ops executed).
    If (enqueued - woken) alias deferred or timedout increaseses
    considerably, you probably need to rise the number of knfsd threads
    handling the workload ;-).
    Jens Elkner committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    920b3ae View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2021

  1. Sync with 'upstream/master' (2021-12-17 749b1a1)

    Jens Elkner committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    423d7eb View commit details
    Browse the repository at this point in the history
  2. Bump Version to 1.3.1.2

    Jens Elkner committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    c156427 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2021

  1. Simplify README.md

    Jens Elkner committed Dec 19, 2021
    Configuration menu
    Copy the full SHA
    9ff9cd8 View commit details
    Browse the repository at this point in the history
Loading