Remove unused config options

jeffmaury · Jun 18, 2021 · cd1adcf · cd1adcf
1 parent c3f46d1
commit cd1adcf
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 40 deletions.
diff --git a/cmd/minikube/cmd/config/config.go b/cmd/minikube/cmd/config/config.go
@@ -122,18 +122,6 @@ var settings = []Setting{
  name: config.ReminderWaitPeriodInHours,
  set: SetInt,
  },
- {
- name: config.WantReportError,
- set: SetBool,
- },
- {
- name: config.WantReportErrorPrompt,
- set: SetBool,
- },
- {
- name: config.WantKubectlDownloadMsg,
- set: SetBool,
- },
  {
  name: config.WantNoneDriverWarning,
  set: SetBool,
@@ -146,14 +134,6 @@ var settings = []Setting{
  name: Bootstrapper,
  set: SetString,
  },
- {
- name: config.ShowDriverDeprecationNotification,
- set: SetBool,
- },
- {
- name: config.ShowBootstrapperDeprecationNotification,
- set: SetBool,
- },
  {
  name: "insecure-registry",
  set: SetString,

diff --git a/cmd/minikube/cmd/root.go b/cmd/minikube/cmd/root.go
@@ -303,12 +303,7 @@ func setupViper() {
 
  viper.SetDefault(config.WantUpdateNotification, true)
  viper.SetDefault(config.ReminderWaitPeriodInHours, 24)
- viper.SetDefault(config.WantReportError, false)
- viper.SetDefault(config.WantReportErrorPrompt, true)
- viper.SetDefault(config.WantKubectlDownloadMsg, true)
  viper.SetDefault(config.WantNoneDriverWarning, true)
- viper.SetDefault(config.ShowDriverDeprecationNotification, true)
- viper.SetDefault(config.ShowBootstrapperDeprecationNotification, true)
 }
 
 func addToPath(dir string) {

diff --git a/pkg/minikube/config/config.go b/pkg/minikube/config/config.go
@@ -36,20 +36,10 @@ const (
  WantBetaUpdateNotification = "WantBetaUpdateNotification"
  // ReminderWaitPeriodInHours is the key for ReminderWaitPeriodInHours
  ReminderWaitPeriodInHours = "ReminderWaitPeriodInHours"
- // WantReportError is the key for WantReportError
- WantReportError = "WantReportError"
- // WantReportErrorPrompt is the key for WantReportErrorPrompt
- WantReportErrorPrompt = "WantReportErrorPrompt"
- // WantKubectlDownloadMsg is the key for WantKubectlDownloadMsg
- WantKubectlDownloadMsg = "WantKubectlDownloadMsg"
  // WantNoneDriverWarning is the key for WantNoneDriverWarning
  WantNoneDriverWarning = "WantNoneDriverWarning"
  // ProfileName represents the key for the global profile parameter
  ProfileName = "profile"
- // ShowDriverDeprecationNotification is the key for ShowDriverDeprecationNotification
- ShowDriverDeprecationNotification = "ShowDriverDeprecationNotification"
- // ShowBootstrapperDeprecationNotification is the key for ShowBootstrapperDeprecationNotification
- ShowBootstrapperDeprecationNotification = "ShowBootstrapperDeprecationNotification"
  // UserFlag is the key for the global user flag (ex. --user=user1)
  UserFlag = "user"
  // AddonImages stores custom addon images config

diff --git a/site/content/en/docs/commands/config.md b/site/content/en/docs/commands/config.md
@@ -29,14 +29,9 @@ Configurable fields:
  * WantUpdateNotification
  * WantBetaUpdateNotification
  * ReminderWaitPeriodInHours
- * WantReportError
- * WantReportErrorPrompt
- * WantKubectlDownloadMsg
  * WantNoneDriverWarning
  * profile
  * bootstrapper
- * ShowDriverDeprecationNotification
- * ShowBootstrapperDeprecationNotification
  * insecure-registry
  * hyperv-virtual-switch
  * disable-driver-mounts