Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make similar weapon waggle (swinging) between DF2 and MotS #71

Open
LukasThyWalls opened this issue Jun 22, 2021 · 4 comments
Open

Make similar weapon waggle (swinging) between DF2 and MotS #71

LukasThyWalls opened this issue Jun 22, 2021 · 4 comments

Comments

@LukasThyWalls
Copy link

LukasThyWalls commented Jun 22, 2021

Hello.

I just beat JK:DF2, with jkgfxmod (mostly vanilla, only with the wheelthingy and the High Detail Mod with any issues and i was going to continue with Mysteries of the Sith, but when i did the setup exactly the same as with DF2, i found the weapons in first person view are going over the place moving for one side to another, being a bit distracting when you are playing.

Looking that i found jkgfxmod make the weapon swinging a bit faster than in the vanilla game, in DF2 and MotS, but in MotS the movement is much faster and wider, making that little bit more much worse than in the DF2 which is more bearable (In fact, i didn't notice any issue until i found it in MotS, so for DF2 i don't think is an issue).

I'm made some videos to show the differences (Warning, crappy recordings ahead):

JK:DF2 Vanilla*

WaggleWeapon_JK_Original.mp4

JK:DF2 with jkgfxmod*

WaggleWeapon_JK_jkgfxmod.mp4

JK:MotS Vanilla*

WaggleWeapon_JKM_Original.mp4

JK:MotS with jkgfxmod*

WaggleWeapon_JKM_jkgfxmod.mp4

I know this issue was touched in the MotS Neural Upscale Special Effect Annex 1.0 and EMSITH (and their DF2 versions), but i didn't want the enhancements, not because i didn't like them, only i want to play the game as close i can to the original game with little quality-of-life enhancements, but also the movement using the FX Annex 1.0 is the opposite to the issue explained here itself: the weapons now are very slow and they don't move at all, not fitting the movement, and, honestly, i don't like how it looks:

JK:MotS with jkgfxmod and FX Annex 1.0 mod*

WaggleWeapon_JKM_jkgfxmod+FXmod.mp4

So, i open some files and did some research with the FX Annex 1.0 mod, i found the weapon swinging (or waggle to the game) is set in the "/cog/weap_*.cog" files, with two lines for each weapon file:

jkSetWaggle(player, '10.0 7.0 0.0', 350);

I don't know what the parameters do, but doing some testing, i changed the two lines of every file to the half in every parameter:

jkSetWaggle(player, '5.0 3.5 0.0', 175);

And now the movement looks much better and in-line with DF2 weapon waggle:

WaggleWeapon_JKM_jkgfxmod+tweak.mp4

I changed that in the same 16 files in the FX Annex 1.0 mod cog files, thinking the other two are not affected to the issue if that mod didn't change them.
There is the files modded (Extract the zip in the Resource folder): JK_MotS_HalfWaggleWeaponSpeedMod.zip
Newish version of the mod JK_MotS_HalfWaggleWeaponSpeedMod.zip as it's uploaded in PCGamingWiki too

However, i found in the weapon cog files in DF2, the values in the parameters in the instruction are the same (jkSetWaggle(player, '10.0 7.0 0.0', 350);), so, in DF2 the jkSetWaggle instruction works different than in MotS, or is other thing in the game. So here is the question of the issue:

There is a way with jkgfxmod to balance this movement to make both games like the original DF2?

Because is not, the only way to make DF2 waggle "slower" is the same as in MotS, with other modded files (Like 3/4 instead of 1/2, maybe?). Like i said, in DF2 is not a big deal, but the issue is there looking the videos side to side.

Thanks for the jkgfxmod, and i hope the tweaked files i made is useful to someone!

(*) Like i said in the beginning, in the game in every recording i'm using too wheelthingy and the High Detail Mod. I point that out because can be any kind of interaction between mods, but i don't think so in this case.

@LukasThyWalls
Copy link
Author

Playing MotS, i just realized something: How the autorun setting works with these games.

In both games, if you have press Bloq Mayus to have Always Run OFF (default key), the player walks slow, or "walks" faster if you press Left Shift (default key). And with Bloq Mayus with Always Run ON, it "walks" faster (seems like with autorun OFF and Left Shift pressed), and if you press Left Shift, runs.

In other games, normally it have two speeds, Walk or Run, and if you have Always Run ON, runs by default and walks if you press the Run key, and viceversa with Always Run OFF.

All the videos above are with Always Run ON. With OFF the player walks very slowly. I don't know if the setting in options changes all of this more, but i don't know... this thing is a bit weird.

@bangstk
Copy link

bangstk commented Jul 29, 2021

They work the same. You are encountering framerate differences between the two games. The HUD Animations start breaking down when the game FPS goes higher than 48. It's likely you have different settings between the two games.

@LukasThyWalls
Copy link
Author

LukasThyWalls commented Jul 30, 2021

They work the same. You are encountering framerate differences between the two games. The HUD Animations start breaking down when the game FPS goes higher than 48. It's likely you have different settings between the two games.

I reinstalled my GOG versions, and i tested like they come in GOG (Software mode only changing the resolution to 1024x768) and latter with jkgfxmod (Hardware mode, only changing the resolution to 1024x768).

And the movement is different.

You can see perfectly in MotS arc of motion of the weapon is bigger than in DF2, as bigger than you can't see the weapon when it's in the lower part of the arc. It's like the weapons appears left and right when the player is running. That not happens in DF2.

And that could be good, but then goes the issue with the speed.

As you said, the framerate can be the issue of the speed of that movement of the weapons, what it's insane for both games when you use jkgfxmod (without mods, it's fast, but not as fast with the mod). Before i said that in DF2 there is no hard issue with the movement, but i did a mistake not playing a new game in every test, as a savegame doesn't reflect the changes if you load them instead of playing a new game (maybe when i passthrough recently the game i was playing without the "Always Run" option, i don't know...) Now i did, and the weapon doesn't "dissapears" as in MotS, but it's ridiculously fast. And in MotS, with that speed and the different movement, you see the weapon appearing and dissapearing in the bottom part of the screen superfast, being worse than in DF2.

I did the same as i did in MotS in DF2, changing jkSetWaggle(player, '10.0 7.0 0.0', 350); to jkSetWaggle(player, '5.0 3.5 0.0', 175); in all resource/cogs/*.cog files and now the weapon movement in both games looks almost the same.

However, if it's like you said, if a different framerate it will go faster (my computer is >10 years, so i can't imagine a newer computer how it is) and my "fix" will only helps me, because others computer could be better with other settings, or maybe not, i don't know.

That's why i write this, to learn what means the parameters in jkSetWaggle, because maybe other parameters could be better. Or maybe can be changed something int he jkgfxmod itself to adapt this to the framerate, but i think it's not the case as the HD mods have to change this also changing the parameters (but as i said before, that eliminates almost all movement and that doesn't look right also).

This is the only "issue" (not a issue, really) i encounter with the two games with jkgfxmod, except to one in the last levels in MotS (Some enemies doesn't use the lightsabers including the last boss). And with the quick fix i posted above, i passthrough MotS with jkgfxmod.

@SpaceCoyot3
Copy link

SpaceCoyot3 commented Jan 9, 2022

Thanks for the noting that FPS affects weapon swaying/bobbing/waggle/swinging animations, @bangstk. I reinstalled jkgfxmod a number of times on both Steam and GoG and played with the config settings trying to figure out why me weapons were moving like crazy when I ran. According to the Steam FPS counter, I was getting FPS between 500 and 700 FPS!

Is there a way you recommend limiting my FPS in Jedi Knight? The best I can do is turn on vsync in the jkgfxmod config but my monitor is 144hz so the weapon sway is still pretty distracting at 144fps. Thanks for any advice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants