{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":669321891,"defaultBranch":"main","name":"wangle","ownerLogin":"jdelliot","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2023-07-21T23:23:12.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/8049604?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1700092408.0","currentOid":""},"activityList":{"items":[{"before":"b0daa9ee903b7ac7fd547a9db4e7ff0b9ab0d5b4","after":"abf7f86725d080640c96c73dee01358d0ddb00eb","ref":"refs/heads/export-D51321500","pushedAt":"2023-11-29T00:28:36.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jdelliot","name":"John Elliott","path":"/jdelliot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8049604?s=80&v=4"},"commit":{"message":"Move sapling_backingstore_get_tree_batch to cxx_bridge\n\nSummary:\nX-link: https://github.com/facebook/folly/pull/2098\n\nX-link: https://github.com/facebook/fbthrift/pull/588\n\ncxx.rs provides a more ergonomic and opinionated interop layer between Rust and C++ that we would like to leverage for future API chages.\n\nThis moves  sapling_backingstore_get_tree_batch from the existing cbindgen implemenation to the new cxxbridge.\n\nReviewed By: xavierd\n\nDifferential Revision: D51321500","shortMessageHtmlLink":"Move sapling_backingstore_get_tree_batch to cxx_bridge"}},{"before":"389606b95ed7dd6def1a9d8968131c2a4e892736","after":"b0daa9ee903b7ac7fd547a9db4e7ff0b9ab0d5b4","ref":"refs/heads/export-D51321500","pushedAt":"2023-11-28T21:35:50.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jdelliot","name":"John Elliott","path":"/jdelliot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8049604?s=80&v=4"},"commit":{"message":"Move sapling_backingstore_get_tree_batch to cxx_bridge\n\nSummary:\ncxx.rs provides a more ergonomic and opinionated interop layer between Rust and C++ that we would like to leverage for future API chages.\n\nThis moves  sapling_backingstore_get_tree_batch from the existing cbindgen implemenation to the new cxxbridge.\n\nReviewed By: xavierd\n\nDifferential Revision: D51321500","shortMessageHtmlLink":"Move sapling_backingstore_get_tree_batch to cxx_bridge"}},{"before":null,"after":"389606b95ed7dd6def1a9d8968131c2a4e892736","ref":"refs/heads/export-D51321500","pushedAt":"2023-11-15T23:53:28.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jdelliot","name":"John Elliott","path":"/jdelliot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8049604?s=80&v=4"},"commit":{"message":"Move sapling_backingstore_get_tree_batch to cxx_bridge\n\nSummary:\nX-link: https://github.com/facebook/mvfst/pull/323\n\nX-link: https://github.com/facebook/hhvm/pull/9413\n\nX-link: https://github.com/facebook/folly/pull/2098\n\nX-link: https://github.com/facebook/fboss/pull/167\n\nX-link: https://github.com/facebookincubator/velox/pull/7595\n\ncxx.rs provides a more ergonomic and opinionated interop layer between Rust and C++ that we would like to leverage for future API chages.\n\nThis moves  sapling_backingstore_get_tree_batch from the existing cbindgen implemenation to the new cxxbridge.\n\nReviewed By: xavierd\n\nDifferential Revision: D51321500","shortMessageHtmlLink":"Move sapling_backingstore_get_tree_batch to cxx_bridge"}},{"before":"1350392c988c41970926203e22bb159ab1e23a47","after":"98dc9a186f68a187a013ff5d5894909f2145a62f","ref":"refs/heads/export-D51160627","pushedAt":"2023-11-14T21:13:15.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jdelliot","name":"John Elliott","path":"/jdelliot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8049604?s=80&v=4"},"commit":{"message":"Add rust_cxx_bridge CMake function\n\nSummary:\nX-link: https://github.com/facebookincubator/hsthrift/pull/120\n\nX-link: https://github.com/facebook/folly/pull/2096\n\nX-link: https://github.com/facebookexperimental/edencommon/pull/14\n\nX-link: https://github.com/facebook/mvfst/pull/322\n\nX-link: https://github.com/facebookincubator/delos_core/pull/9\n\nX-link: https://github.com/facebook/fboss/pull/166\n\nX-link: https://github.com/facebookincubator/zstrong/pull/617\n\nX-link: https://github.com/facebookincubator/katran/pull/208\n\nX-link: https://github.com/facebookincubator/fizz/pull/102\n\nX-link: https://github.com/facebookexternal/traffixr/pull/4\n\nX-link: https://github.com/facebook/watchman/pull/1173\n\nX-link: https://github.com/facebook/proxygen/pull/473\n\nX-link: https://github.com/facebook/hhvm/pull/9411\n\nX-link: https://github.com/facebook/fbthrift/pull/587\n\nX-link: https://github.com/facebookincubator/velox/pull/7518\n\nWe need a better way to create cxxbridges - something that uses the recommended method of cxxbridge-cmd.\n\nThis function creates C++ bindings using the [cxx] crate.\n\nOriginal function found here: https://github.com/corrosion-rs/corrosion/blob/master/cmake/Corrosion.cmake#L1390\n\nReviewed By: xavierd\n\nDifferential Revision: D51160627","shortMessageHtmlLink":"Add rust_cxx_bridge CMake function"}},{"before":"8af74f28d59c43605ba9611afe378c49d74d5e3c","after":"1350392c988c41970926203e22bb159ab1e23a47","ref":"refs/heads/export-D51160627","pushedAt":"2023-11-13T17:31:35.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jdelliot","name":"John Elliott","path":"/jdelliot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8049604?s=80&v=4"},"commit":{"message":"Add rust_cxx_bridge CMake function\n\nSummary:\nX-link: https://github.com/facebook/folly/pull/2096\n\nX-link: https://github.com/facebookexperimental/edencommon/pull/14\n\nX-link: https://github.com/facebook/mvfst/pull/322\n\nX-link: https://github.com/facebookincubator/delos_core/pull/9\n\nX-link: https://github.com/facebook/fboss/pull/166\n\nX-link: https://github.com/facebookincubator/zstrong/pull/617\n\nX-link: https://github.com/facebookincubator/katran/pull/208\n\nX-link: https://github.com/facebookincubator/fizz/pull/102\n\nX-link: https://github.com/facebookexternal/traffixr/pull/4\n\nX-link: https://github.com/facebook/watchman/pull/1173\n\nX-link: https://github.com/facebook/proxygen/pull/473\n\nX-link: https://github.com/facebook/hhvm/pull/9411\n\nX-link: https://github.com/facebook/fbthrift/pull/587\n\nX-link: https://github.com/facebookincubator/velox/pull/7518\n\nWe need a better way to create cxxbridges - something that uses the recommended method of cxxbridge-cmd.\n\nThis function creates C++ bindings using the [cxx] crate.\n\nOriginal function found here: https://github.com/corrosion-rs/corrosion/blob/master/cmake/Corrosion.cmake#L1390\n\nReviewed By: xavierd\n\nDifferential Revision: D51160627","shortMessageHtmlLink":"Add rust_cxx_bridge CMake function"}},{"before":"8c70d1159b6b284103bedf4483cc348dfa9d8e95","after":"8af74f28d59c43605ba9611afe378c49d74d5e3c","ref":"refs/heads/export-D51160627","pushedAt":"2023-11-12T06:54:11.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jdelliot","name":"John Elliott","path":"/jdelliot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8049604?s=80&v=4"},"commit":{"message":"Add rust_cxx_bridge CMake function\n\nSummary:\nX-link: https://github.com/facebookexperimental/edencommon/pull/14\n\nX-link: https://github.com/facebook/mvfst/pull/322\n\nX-link: https://github.com/facebookincubator/delos_core/pull/9\n\nX-link: https://github.com/facebook/fboss/pull/166\n\nX-link: https://github.com/facebookincubator/zstrong/pull/617\n\nX-link: https://github.com/facebookincubator/katran/pull/208\n\nX-link: https://github.com/facebookincubator/fizz/pull/102\n\nX-link: https://github.com/facebookexternal/traffixr/pull/4\n\nX-link: https://github.com/facebook/watchman/pull/1173\n\nX-link: https://github.com/facebook/proxygen/pull/473\n\nX-link: https://github.com/facebook/hhvm/pull/9411\n\nX-link: https://github.com/facebook/fbthrift/pull/587\n\nX-link: https://github.com/facebookincubator/velox/pull/7518\n\nWe need a better way to create cxxbridges - something that uses the recommended method of cxxbridge-cmd.\n\nThis function creates C++ bindings using the [cxx] crate.\n\nOriginal function found here: https://github.com/corrosion-rs/corrosion/blob/master/cmake/Corrosion.cmake#L1390\n\nDifferential Revision: D51160627","shortMessageHtmlLink":"Add rust_cxx_bridge CMake function"}},{"before":"c86230a3ef6f3034af68b41f636bfe60e31f5d3e","after":"8c70d1159b6b284103bedf4483cc348dfa9d8e95","ref":"refs/heads/export-D51160627","pushedAt":"2023-11-11T20:19:23.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jdelliot","name":"John Elliott","path":"/jdelliot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8049604?s=80&v=4"},"commit":{"message":"Add rust_cxx_bridge CMake function\n\nSummary:\nX-link: https://github.com/facebook/mvfst/pull/322\n\nX-link: https://github.com/facebookincubator/delos_core/pull/9\n\nX-link: https://github.com/facebook/fboss/pull/166\n\nX-link: https://github.com/facebookincubator/zstrong/pull/617\n\nX-link: https://github.com/facebookincubator/katran/pull/208\n\nX-link: https://github.com/facebookincubator/fizz/pull/102\n\nX-link: https://github.com/facebookexternal/traffixr/pull/4\n\nX-link: https://github.com/facebook/watchman/pull/1173\n\nX-link: https://github.com/facebook/proxygen/pull/473\n\nX-link: https://github.com/facebook/hhvm/pull/9411\n\nX-link: https://github.com/facebook/fbthrift/pull/587\n\nX-link: https://github.com/facebookincubator/velox/pull/7518\n\nWe need a better way to create cxxbridges - something that uses the recommended method of cxxbridge-cmd.\n\nThis function creates C++ bindings using the [cxx] crate.\n\nOriginal function found here: https://github.com/corrosion-rs/corrosion/blob/master/cmake/Corrosion.cmake#L1390\n\nDifferential Revision: D51160627","shortMessageHtmlLink":"Add rust_cxx_bridge CMake function"}},{"before":"76150d4983fd0c21c09a76258a0b69f27cade5bc","after":"c86230a3ef6f3034af68b41f636bfe60e31f5d3e","ref":"refs/heads/export-D51160627","pushedAt":"2023-11-11T20:14:24.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jdelliot","name":"John Elliott","path":"/jdelliot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8049604?s=80&v=4"},"commit":{"message":"Add rust_cxx_bridge CMake function\n\nSummary:\nX-link: https://github.com/facebookincubator/delos_core/pull/9\n\nX-link: https://github.com/facebook/fboss/pull/166\n\nX-link: https://github.com/facebookincubator/zstrong/pull/617\n\nX-link: https://github.com/facebookincubator/katran/pull/208\n\nX-link: https://github.com/facebookincubator/fizz/pull/102\n\nX-link: https://github.com/facebookexternal/traffixr/pull/4\n\nX-link: https://github.com/facebook/watchman/pull/1173\n\nX-link: https://github.com/facebook/proxygen/pull/473\n\nX-link: https://github.com/facebook/hhvm/pull/9411\n\nX-link: https://github.com/facebook/fbthrift/pull/587\n\nX-link: https://github.com/facebookincubator/velox/pull/7518\n\nWe need a better way to create cxxbridges - something that uses the recommended method of cxxbridge-cmd.\n\nThis function creates C++ bindings using the [cxx] crate.\n\nOriginal function found here: https://github.com/corrosion-rs/corrosion/blob/master/cmake/Corrosion.cmake#L1390\n\nDifferential Revision: D51160627","shortMessageHtmlLink":"Add rust_cxx_bridge CMake function"}},{"before":"4cd5bde7d696302920cf3d60343ae3d9559b2631","after":"76150d4983fd0c21c09a76258a0b69f27cade5bc","ref":"refs/heads/export-D51160627","pushedAt":"2023-11-11T08:37:48.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jdelliot","name":"John Elliott","path":"/jdelliot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8049604?s=80&v=4"},"commit":{"message":"Add rust_cxx_bridge CMake function\n\nSummary:\nX-link: https://github.com/facebook/fboss/pull/166\n\nX-link: https://github.com/facebookincubator/zstrong/pull/617\n\nX-link: https://github.com/facebookincubator/katran/pull/208\n\nX-link: https://github.com/facebookincubator/fizz/pull/102\n\nX-link: https://github.com/facebookexternal/traffixr/pull/4\n\nX-link: https://github.com/facebook/watchman/pull/1173\n\nX-link: https://github.com/facebook/proxygen/pull/473\n\nX-link: https://github.com/facebook/hhvm/pull/9411\n\nX-link: https://github.com/facebook/fbthrift/pull/587\n\nX-link: https://github.com/facebookincubator/velox/pull/7518\n\nWe need a better way to create cxxbridges - something that uses the recommended method of cxxbridge-cmd.\n\nThis function creates C++ bindings using the [cxx] crate.\n\nOriginal function found here: https://github.com/corrosion-rs/corrosion/blob/master/cmake/Corrosion.cmake#L1390\n\nDifferential Revision: D51160627","shortMessageHtmlLink":"Add rust_cxx_bridge CMake function"}},{"before":"f4ebdacb994cd0c2afb09033c6353b2d87f074cd","after":"4cd5bde7d696302920cf3d60343ae3d9559b2631","ref":"refs/heads/export-D51160627","pushedAt":"2023-11-10T23:19:19.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jdelliot","name":"John Elliott","path":"/jdelliot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8049604?s=80&v=4"},"commit":{"message":"Add rust_cxx_bridge CMake function\n\nSummary:\nX-link: https://github.com/facebookincubator/zstrong/pull/617\n\nX-link: https://github.com/facebookincubator/katran/pull/208\n\nX-link: https://github.com/facebookincubator/fizz/pull/102\n\nX-link: https://github.com/facebookexternal/traffixr/pull/4\n\nX-link: https://github.com/facebook/watchman/pull/1173\n\nX-link: https://github.com/facebook/proxygen/pull/473\n\nX-link: https://github.com/facebook/hhvm/pull/9411\n\nX-link: https://github.com/facebook/fbthrift/pull/587\n\nX-link: https://github.com/facebookincubator/velox/pull/7518\n\nWe need a better way to create cxxbridges - something that uses the recommended method of cxxbridge-cmd.\n\nThis function creates C++ bindings using the [cxx] crate.\n\nOriginal function found here: https://github.com/corrosion-rs/corrosion/blob/master/cmake/Corrosion.cmake#L1390\n\nDifferential Revision: D51160627","shortMessageHtmlLink":"Add rust_cxx_bridge CMake function"}},{"before":null,"after":"f4ebdacb994cd0c2afb09033c6353b2d87f074cd","ref":"refs/heads/export-D51160627","pushedAt":"2023-11-10T19:59:09.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jdelliot","name":"John Elliott","path":"/jdelliot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8049604?s=80&v=4"},"commit":{"message":"Add rust_cxx_bridge CMake function\n\nSummary:\nX-link: https://github.com/facebook/proxygen/pull/473\n\nX-link: https://github.com/facebook/hhvm/pull/9411\n\nX-link: https://github.com/facebook/fbthrift/pull/587\n\nX-link: https://github.com/facebookincubator/velox/pull/7518\n\nWe need a better way to create cxxbridges - something that uses the recommended method of cxxbridge-cmd.\n\nThis function creates C++ bindings using the [cxx] crate.\n\nOriginal function found here: https://github.com/corrosion-rs/corrosion/blob/master/cmake/Corrosion.cmake#L1390\n\nDifferential Revision: D51160627","shortMessageHtmlLink":"Add rust_cxx_bridge CMake function"}},{"before":"4c98c7116a5108c24da1a49cae5ca7f84225cacf","after":"5c83ee938f3d531f382e080bc34bf4ca5f52e2fe","ref":"refs/heads/export-D50772544","pushedAt":"2023-10-30T16:44:04.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jdelliot","name":"John Elliott","path":"/jdelliot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8049604?s=80&v=4"},"commit":{"message":"Paramatized rust_static_library to enable CXX support (#221)\n\nSummary:\nX-link: https://github.com/facebookincubator/delos_core/pull/8\n\nX-link: https://github.com/facebookincubator/zstrong/pull/610\n\nX-link: https://github.com/facebookincubator/crux/pull/10\n\nX-link: https://github.com/facebookexternal/traffixr/pull/3\n\nX-link: https://github.com/facebookincubator/katran/pull/205\n\nX-link: https://github.com/facebookincubator/fizz/pull/101\n\nX-link: https://github.com/facebook/sapling/pull/763\n\nX-link: https://github.com/facebookexperimental/rust-shed/pull/43\n\n\nX-link: https://github.com/facebook/openr/pull/150\n\nX-link: https://github.com/facebook/hhvm/pull/9403\n\nX-link: https://github.com/facebook/folly/pull/2092\n\nX-link: https://github.com/facebook/fb303/pull/42\n\nX-link: https://github.com/facebookincubator/velox/pull/7301\n\nWe are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.\n\nReviewed By: xavierd\n\nDifferential Revision: D50772544","shortMessageHtmlLink":"Paramatized rust_static_library to enable CXX support (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1966780269\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/wangle/issues/221\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/wangle/pull/221/hovercard\" href=\"https://github.com/facebook/wangle/pull/221\">facebook#221</a>)"}},{"before":"7c977e626a396aff0ee945525ad0fd1d8c8cb449","after":"4c98c7116a5108c24da1a49cae5ca7f84225cacf","ref":"refs/heads/export-D50772544","pushedAt":"2023-10-29T22:12:42.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jdelliot","name":"John Elliott","path":"/jdelliot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8049604?s=80&v=4"},"commit":{"message":"Paramatized rust_static_library to enable CXX support (#221)\n\nSummary:\nX-link: https://github.com/facebookincubator/zstrong/pull/610\n\nX-link: https://github.com/facebookincubator/crux/pull/10\n\nX-link: https://github.com/facebookexternal/traffixr/pull/3\n\nX-link: https://github.com/facebookincubator/katran/pull/205\n\nX-link: https://github.com/facebookincubator/fizz/pull/101\n\nX-link: https://github.com/facebook/sapling/pull/763\n\nX-link: https://github.com/facebookexperimental/rust-shed/pull/43\n\n\nX-link: https://github.com/facebook/openr/pull/150\n\nX-link: https://github.com/facebook/hhvm/pull/9403\n\nX-link: https://github.com/facebook/folly/pull/2092\n\nX-link: https://github.com/facebook/fb303/pull/42\n\nX-link: https://github.com/facebookincubator/velox/pull/7301\n\nWe are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.\n\nDifferential Revision: D50772544","shortMessageHtmlLink":"Paramatized rust_static_library to enable CXX support (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1966780269\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/wangle/issues/221\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/wangle/pull/221/hovercard\" href=\"https://github.com/facebook/wangle/pull/221\">facebook#221</a>)"}},{"before":null,"after":"7c977e626a396aff0ee945525ad0fd1d8c8cb449","ref":"refs/heads/export-D50772544","pushedAt":"2023-10-29T00:14:28.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jdelliot","name":"John Elliott","path":"/jdelliot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8049604?s=80&v=4"},"commit":{"message":"Paramatized rust_static_library to enable CXX support\n\nSummary:\nX-link: https://github.com/facebook/openr/pull/150\n\nX-link: https://github.com/facebook/hhvm/pull/9403\n\nX-link: https://github.com/facebook/folly/pull/2092\n\nX-link: https://github.com/facebook/fb303/pull/42\n\nX-link: https://github.com/facebookincubator/velox/pull/7301\n\nWe are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.\n\nDifferential Revision: D50772544","shortMessageHtmlLink":"Paramatized rust_static_library to enable CXX support"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAADumCGWgA","startCursor":null,"endCursor":null}},"title":"Activity · jdelliot/wangle"}