-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: able to manually add keywords to parse #9
Comments
hi surely there is a list of sensitive keywords, parsed as a regex, found here keeping your own list of sensitive words or in other words, letting user manage the list, is another way to do it, but creating an issue and contributing to the source code helps everyone on capturing the codes, not just yourself. and we can add more tests over time and ensure that adding/removing something does not break the code extraction of already known messages. |
Currently I don't have time to add this new feature, but if someone adds such a feature in a PR, in a way that is updatable by updates, while keeping user data/settings, and providing a good UX, I would be happy to merge it (please state that you are going to work on it if you are going to, before doing it, to avoid problems later) meanwhile, should we add |
I've added |
Hey @jd1378, I really like your app. But I think the way you handle keywords is too static. In order to get something to work in other languages or code types, you have to raise a PR here and wait for a new release. If you drop this project one day, new users will not find this app usable. Also, you're making the app available through different app stores, which in the case of googleplay means that most users may not have a github account and know how to make the app work for their keywords. Please consider a custom list of keywords that will also be useful for testing. People who want to contribute will continue to do so, but making the usability of the app completely dependent on releases and fixed strings in the repo is not future-first. Thanks for the app, I hope to be able to use it with my own keywords that may not be suitable for others. |
Hi @nvllz Either the project needs to have financial support for me to put more time on it, or have contributors help me in adding features or improving the app |
Sure, I understand your point of view. You spent some time developing it and you want it to be used on your terms. I just wanted to point out that the current way of managing keywords will probably cost you more time with more keywords to add and possible unwanted detections by others, meaning more PRs/issue tickets for individual words. You've made a very useful application, but the end user can't control the keywords manually (there's probably an option to blacklist some notifications, but I couldn't test it), and that's a problem. No offense to you, just saying how I see it. I couldn't even test it because the app doesn't handle the keywords I want. And while it may be useful for me to have them copied automatically, others may find it annoying and make a PR to undo my changes. A custom keywords list would give longevity to the project, as you seem to not accept donations and may just stop development one day. I just want you to think again and change your mind, because this kind of static attitude may cost you more attention, and since you don't have much time, new keyword PRs will not be addressed. Cheers. |
I understand and I try to implement the feature, just that it may take a while |
@jd1378 First and foremost, I'm using the app and it's great. So nifty and useful! Just because of its usefulness, just dropping another solution to a problem stated above. |
I also second the idea of having per-user configurable keywords. While the idea of having it hard-coded "for the benefit of all" sounds charming at first, there is no "one size fits all" solution and you will not be able to please everyone. E.g. in your static list, there already is |
Hi Thanks for helping improve the app with your suggestions |
That's great, @jd1378! Thank you. |
Good idea, sounds useful for testing for example on regex101.com |
Hi please try and let me know if you have any issues |
Hey, |
sorry for the notifications this is probably the final rc (rest is waiting for translators to translate the new entries) |
I have added new keywords and removed default ones. Works fine for me so far. 👍 |
Hello.
Well, all is in the title of issue.
I receive sms in russian and without any special tags like <#>.
Just
ваш код: 654321
Also may be
код подтверждения
,код доступа
and so on.And otphelper not parse it.
Such ways to deal with it:
Every not-English-speaking guy, who wants to use otphelper, creates his own wordlist or/and algoritm right inside an app.
1.1. And if we are all kindful people, then we have to share the wordlist for improving the tool.
I may to collect my sms, analyse and create algorithms, like so for English or Arabian if any.
Or app is running simply as (WATCH PATTERN <#>) ?
The text was updated successfully, but these errors were encountered: