forked from dajobe/flickcurl
-
Notifications
You must be signed in to change notification settings - Fork 0
/
ChangeLog
4890 lines (3262 loc) · 149 KB
/
ChangeLog
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
2012-09-01 Dave Beckett <[email protected]>
* Snapshotted flickcurl_1_23 for 1.23 release (GIT
29b6f5b550599ce9398504b975c784eac4cb2ba1)
* docs/flickcurl-authenticate.xml, docs/flickcurl-oauth.xml: docs
* utils/flickcurl.c: Add oauth.verify command to upgrade legacy
auth to OAuth
* docs/flickcurl-authenticate.xml, docs/flickcurl-oauth.xml: More
oauth docs
* docs/Makefile.am, docs/flickcurl-authenticate.xml,
docs/flickcurl-docs.xml, docs/flickcurl-oauth.xml: OAuth docs
2012-08-31 Dave Beckett <[email protected]>
* autogen.sh: autogen.sh docs
* autogen.sh, configure.ac: Update autogen.sh and configure.ac via
autoupdate
2012-08-29 Dave Beckett <[email protected]>
* NEWS.html: words
* NEWS.html: html
2012-08-28 Dave Beckett <[email protected]>
* src/oauth.c:
(test_request_token): Fix call to
flickcurl_oauth_create_request_token
* utils/Makefile.am, utils/oauth-test.c: Remove oauth-test utility
no longer needed
* docs/tmpl/section-auth.sgml, docs/tmpl/section-core.sgml,
docs/tmpl/section-misc.sgml: Update tmpls
* docs/flickcurl-sections.txt: Add new functions to sections
* src/collection.c, src/common.c, src/gallery.c, src/person.c,
src/photo.c: Replace strncpy with memcpy
* ChangeLog: #changes
* src/oauth.c: Remove final strcat from OAuth code
(flickcurl_oauth_prepare_common): replaced strcat with pointer
movement and memcpy
* src/oauth.c: Remove strcpy and stract from OAuth code
(flickcurl_oauth_prepare_common): strcpy and strcat replaced with
pointer movement and memcpy
* src/photo.c:
(flickcurl_user_icon_uri): 42
* src/photo.c:
(flickcurl_photo_as_source_uri): Remove strcpy
* src/machinetags.c: Switch to strlen / malloc / memcpy form
(flickcurl_build_tag_namespaces,
flickcurl_build_tag_predicate_values):
Switch from sequence:
dest = malloc(strlen(str) + 1);
strcpy(dest, str);
to
len = strlen(str)
dest = malloc(len + 1)
memcpy(dest, str, len + 1)
to get rid of strcpy for known string length
* src/legacy-auth.c: Remove strcpy from legacy auth code
(flickcurl_legacy_prepare_common): Lots of url and parameter
counting. strcpy and strcat replaced with pointer movement and
memcpy
* src/args.c:
(flickcurl_build_args): Fix strlen/malloc/memcpy cut-n-pasto
* src/activity.c, src/args.c, src/blog.c, src/category.c,
src/comments.c, src/contacts.c, src/context.c, src/exif.c,
src/gallery.c, src/group.c, src/members.c, src/note.c,
src/oauth.c, src/panda-api.c, src/perms.c, src/photos-api.c,
src/photos-licenses-api.c, src/photoset.c, src/place.c,
src/reflection-api.c, src/serializer.c, src/size.c, src/stat.c,
src/tags.c, src/ticket.c, src/user_upload_status.c, src/common.c:
Switch to strlen / malloc / memcpy form for setters
Switch from sequence:
dest = malloc(strlen(str) + 1);
strcpy(dest, str);
to
len = strlen(str)
dest = malloc(len + 1)
memcpy(dest, str, len + 1)
to get rid of strcpy for known string length
(flickcurl_set_user_agent, flickcurl_set_proxy,
flickcurl_set_http_accept): swtich from "malloc(strcpy); strcpy"
to "strlen(); malloc(); memcpy()" sequence
(flickcurl_invoke_common): Use same for raptor building URIs from
filename.
* src/common.c, src/legacy-auth.c, src/oauth.c, src/photo.c:
Change slightly unportable strdup() with malloc + memcpy
* src/group.c: Free attribute values if not used [clang]
(flickcurl_build_groups): Free value from child node always
* libmtwist: Update submodule libmtwist
* src/upload-api.c: Free status on error path [clang]
(flickcurl_photos_upload_params, flickcurl_photos_replace): Free
status on error exist.
* src/ticket.c: Free attribute values if not used [clang]
(flickcurl_build_tickets): Free attr_value
* src/tags.c: Free attribute values if not used. Free vars in loop
[clang]
(flickcurl_build_tags): Free attr_value
(flickcurl_build_tags_from_string): Use memcpy for known length
string.
(flickcurl_build_tag_clusters): Free tc on loop skip Free tag
cluster on error exit.
* src/stats-api.c: Initialise vars for errors. Free results on an
error [clang]
(flickcurl_stats_getCollectionStats,
flickcurl_stats_getPhotosetStats,
flickcurl_stats_getPhotostreamStats): Initialize count vars for
error case.
(flickcurl_stats_getTotalViews): Initialize count vars for error
case. Free views on error exits
* src/stat.c:
Free attribute values if not used [clang]
(flickcurl_build_stats): Free attr_value
* src/size.c:
Free attribute values if not used [clang]
(flickcurl_build_sizes): Free attr_value
* src/shape.c:
Free results on an error [clang]
(flickcurl_build_shapes): Free shapes on error exits
* src/place.c: Free results on an error, attribute values, calloc
fixes [clang]
(flickcurl_build_places): Free places on error exits
(flickcurl_build_place_types): Calloc correct object
pointer (semantic error but not dangerous). Calloc correct
parameter order. Free attribute value if not used.
* src/photos-licenses-api.c: Free attribute values if not used
[clang]
(flickcurl_read_licenses): Free attr_value
* src/photos-api.c: Free attribute values if not used and objects
on error path [clang]
(flickcurl_build_photocounts): Free attr_value
(flickcurl_photos_getCounts): Free counts on error exit
* src/photo.c: Free results on an error [clang]
(flickcurl_build_photos): Free photos on error exits
(flickcurl_invoke_photos_list): Check for NULL photos_list before
trying to call it
* src/perms.c:
Free attribute values if not used [clang]
(flickcurl_build_perms): Free attr_value
* src/panda-api.c:
Free results on an error [clang]
(flickcurl_panda_getList): Free pandas on error exits
* src/note.c:
Free attribute values if not used [clang]
(flickcurl_build_notes): Free attr_value
* src/method.c:
Free results on an error [clang]
(flickcurl_build_method): Free method on error exits
* src/machinetags.c: Free attribute values if not used [clang]
(flickcurl_build_tag_namespaces,
flickcurl_build_tag_predicate_values): Free attr_value
* src/location.c: Memcpy and attribute value fixes [clang]
(flickcurl_build_location): memcpy instead of strcpy. Always free
attribute value.
* src/institution.c: Free results on an error [clang]
(flickcurl_build_institutions): Free institutions on error exits
* src/favorites-api.c: Free results on an error [clang]
(flickcurl_favorites_getContext): Do not set an unused value. Free
photos lists on error exits
* src/exif.c: Free attribute values if not used [clang]
(flickcurl_build_exifs): Free attr_value
* src/context.c: Fix allocation and freeing attribute values
[clang]
(flickcurl_build_contexts): Calloc correct sized pointer (no
danger, but a semantic error). Free unused attribute values.
* src/common.c: Set a return value always [clang]
(flickcurl_prepare_common): Set rc and use memcpy for string
* src/collection.c: Free results on an error [clang]
(flickcurl_build_collections): Free collections on error exits
* src/category.c: Free attribute values if not used [clang]
(flickcurl_build_categories): Free attr_value
* src/blog.c: Free attribute values if not used [clang]
(flickcurl_build_blogs, flickcurl_build_blog_services): Free
attr_value
* src/.gitignore, src/Makefile.am: Add analyze target for source
* configure.ac: Add RECHO, RECHO_C, RECHO_N
* analyze
* src/oauth.c: Remove final strcat from OAuth code
(flickcurl_oauth_prepare_common): replaced strcat with pointer
movement and memcpy
* src/oauth.c: Remove strcpy and stract from OAuth code
(flickcurl_oauth_prepare_common): strcpy and strcat replaced with
pointer movement and memcpy
* src/photo.c:
(flickcurl_user_icon_uri): 42
* src/photo.c:
(flickcurl_photo_as_source_uri): Remove strcpy
* src/machinetags.c: Switch to strlen / malloc / memcpy form
(flickcurl_build_tag_namespaces,
flickcurl_build_tag_predicate_values): Switch from sequence:
dest = malloc(strlen(str) + 1)
strcpy(dest, str)
to
len = strlen(str)
dest = malloc(len + 1)
memcpy(dest, str, len + 1)
to get rid of strcpy for known string length
* src/legacy-auth.c: Remove strcpy from legacy auth code
(flickcurl_legacy_prepare_common): Lots of url and parameter
counting. strcpy and strcat replaced with pointer movement and
memcpy
* src/args.c:
(flickcurl_build_args): Fix strlen/malloc/memcpy cut-n-pasto
* src/activity.c, src/args.c, src/blog.c, src/category.c,
src/comments.c, src/contacts.c, src/context.c, src/exif.c,
src/gallery.c, src/group.c, src/members.c, src/note.c,
src/oauth.c, src/panda-api.c, src/perms.c, src/photos-api.c,
src/photos-licenses-api.c, src/photoset.c, src/place.c,
src/reflection-api.c, src/serializer.c, src/size.c, src/stat.c,
src/tags.c, src/ticket.c, src/user_upload_status.c: Switch to
strlen / malloc / memcpy form for setters
Switch from sequence:
dest = malloc(strlen(str) + 1)
strcpy(dest, str)
to
len = strlen(str)
dest = malloc(len + 1)
memcpy(dest, str, len + 1)
to get rid of strcpy for known string length
* src/common.c: Switch to strlen / malloc / memcpy form for
setters
(flickcurl_set_user_agent, flickcurl_set_proxy,
flickcurl_set_http_accept): swtich from "malloc(strcpy); strcpy"
to "strlen(); malloc(); memcpy()" sequence
(flickcurl_invoke_common): Use same for raptor building URIs from
filename.
* src/common.c, src/legacy-auth.c, src/oauth.c, src/photo.c:
Change slightly unportable strdup() with malloc + memcpy
* src/group.c: Free attribute values if not used [clang]
(flickcurl_build_groups): Free value from child node always
* libmtwist:
Update submodule libmtwist
* src/upload-api.c: Free status on error path [clang]
(flickcurl_photos_upload_params, flickcurl_photos_replace): Free
status on error exist.
* src/ticket.c: Free attribute values if not used [clang]
(flickcurl_build_tickets): Free attr_value
* src/tags.c: Free attribute values if not used. Free vars in loop
[clang]
(flickcurl_build_tags): Free attr_value
(flickcurl_build_tags_from_string): Use memcpy for known length
string.
(flickcurl_build_tag_clusters): Free tc on loop skip Free tag
cluster on error exit.
* src/stats-api.c: Initialise vars for errors. Free results on an
error [clang]
(flickcurl_stats_getCollectionStats,
flickcurl_stats_getPhotosetStats,
flickcurl_stats_getPhotostreamStats): Initialize count vars for
error case.
(flickcurl_stats_getTotalViews): Initialize count vars for error
case. Free views on error exits
* src/stat.c: Free attribute values if not used [clang]
(flickcurl_build_stats): Free attr_value
* src/size.c: Free attribute values if not used [clang]
(flickcurl_build_sizes): Free attr_value
* src/shape.c: Free results on an error [clang]
(flickcurl_build_shapes): Free shapes on error exits
* src/place.c: Free results on an error, attribute values, calloc
fixes [clang]
(flickcurl_build_places): Free places on error exits
(flickcurl_build_place_types): Calloc correct object
pointer (semantic error but not dangerous). Calloc correct
parameter order. Free attribute value if not used.
* src/photos-licenses-api.c: Free attribute values if not used
[clang]
(flickcurl_read_licenses): Free attr_value
* src/photos-api.c: Free attribute values if not used and objects
on error path [clang]
(flickcurl_build_photocounts): Free attr_value
(flickcurl_photos_getCounts): Free counts on error exit
* src/photo.c: Free results on an error [clang]
(flickcurl_build_photos): Free photos on error exits
(flickcurl_invoke_photos_list): Check for NULL photos_list before
trying to call it
* src/perms.c: Free attribute values if not used [clang]
(flickcurl_build_perms): Free attr_value
* src/panda-api.c: Free results on an error [clang]
(flickcurl_panda_getList): Free pandas on error exits
* src/note.c: Free attribute values if not used [clang]
(flickcurl_build_notes): Free attr_value
* src/method.c: Free results on an error [clang]
(flickcurl_build_method): Free method on error exits
* src/machinetags.c: Free attribute values if not used [clang]
(flickcurl_build_tag_namespaces,
flickcurl_build_tag_predicate_values): Free attr_value
* src/location.c: Memcpy and attribute value fixes [clang]
(flickcurl_build_location): memcpy instead of strcpy. Always free
attribute value.
* src/institution.c: Free results on an error [clang]
(flickcurl_build_institutions): Free institutions on error exits
* src/favorites-api.c: Free results on an error [clang]
(flickcurl_favorites_getContext): Do not set an unused value.
Free photos lists on error exits
* src/exif.c: Free attribute values if not used [clang]
(flickcurl_build_exifs): Free attr_value
* src/context.c: Fix allocation and freeing attribute values
[clang]
(flickcurl_build_contexts): Calloc correct sized pointer (no
danger, but a semantic error). Free unused attribute values.
* src/common.c: Set a return value always [clang]
(flickcurl_prepare_common): Set rc and use memcpy for string
* src/collection.c: Free results on an error [clang]
(flickcurl_build_collections): Free collections on error exits
* src/category.c: Free attribute values if not used [clang]
(flickcurl_build_categories): Free attr_value
* src/blog.c: Free attribute values if not used [clang]
(flickcurl_build_blogs, flickcurl_build_blog_services): Free
attr_value
* src/.gitignore, src/Makefile.am: Add analyze target for source
* configure.ac: Add RECHO, RECHO_C, RECHO_N
* src/Makefile.am: analyze
2012-08-27 Dave Beckett <[email protected]>
* NEWS.html: 1.23
* NEWS.html: new APIs
* src/common.c, src/flickcurl.h, src/oauth.c, utils/flickcurl.c:
Split oauth request token/secret setting into two functions
(flickcurl_set_oauth_request_credentials): Deleted
(flickcurl_set_oauth_request_token,
flickcurl_set_oauth_request_token_secret): Added, replacing above.
* NEWS.html: OAuth API calls
* NEWS.html: 1.23
2012-08-27 Dave Beckett <[email protected]>
* src/oauth.c: Remove unused parameters vars
(flickcurl_oauth_create_request_token,
flickcurl_oauth_create_access_token): Use flickcurl_end_params()
and count for form field counting
* src/flickcurl.h, src/flickcurl_internal.h,
src/win32_flickcurl_config.h: 2012
* utils/codegen.c, utils/flickcurl.c, utils/flickrdf.c,
utils/list-methods.c, utils/oauth-test.c, utils/raptor_fake.c,
utils/raptor_fake.h: 2012
* src/activity-api.c, src/auth-api.c, src/blogs-api.c,
src/collection.c, src/collections-api.c, src/common.c,
src/commons-api.c, src/config.c, src/contacts-api.c,
src/favorites-api.c, src/galleries-api.c, src/groups-api.c,
src/groups-members-api.c, src/groups-pools-api.c,
src/interestingness-api.c, src/machinetags-api.c, src/oauth.c,
src/panda-api.c, src/people-api.c, src/person.c, src/photo.c,
src/photos-api.c, src/photos-comments-api.c, src/photos-geo-api.c,
src/photos-licenses-api.c, src/photos-notes-api.c,
src/photos-people-api.c, src/photos-transform-api.c,
src/photos-upload-api.c, src/photosets-api.c,
src/photosets-comments-api.c, src/places-api.c, src/prefs-api.c,
src/reflection-api.c, src/serializer.c, src/stats-api.c,
src/tags-api.c, src/test-api.c, src/upload-api.c, src/urls-api.c:
2012
2012-08-26 Dave Beckett <[email protected]>
* src/places-api.c, src/reflection-api.c: Update count parameter
use to new style here too
* src/activity-api.c, src/auth-api.c, src/blogs-api.c,
src/collections-api.c, src/common.c, src/commons-api.c,
src/contacts-api.c, src/favorites-api.c, src/flickcurl_internal.h,
src/galleries-api.c, src/groups-api.c, src/groups-members-api.c,
src/groups-pools-api.c, src/interestingness-api.c,
src/legacy-auth.c, src/machinetags-api.c, src/oauth.c,
src/panda-api.c, src/people-api.c, src/photos-api.c,
src/photos-comments-api.c, src/photos-geo-api.c,
src/photos-licenses-api.c, src/photos-notes-api.c,
src/photos-people-api.c, src/photos-transform-api.c,
src/photos-upload-api.c, src/photosets-api.c,
src/photosets-comments-api.c, src/places-api.c, src/prefs-api.c,
src/reflection-api.c, src/stats-api.c, src/tags-api.c,
src/test-api.c, src/upload-api.c: Move all use of 'count' var to
use fc->count
(flickcurl_init_params, flickcurl_add_param, flickcurl_end_param):
Added and used in every API call to replace by-hand construction
of params and adjusting count variable.
(flickcurl_prepare_common, flickcurl_legacy_prepare_common,
flickcurl_oauth_prepare_common, flickcurl_prepare_noauth,
flickcurl_prepare): Lose count param and use fc->count directly
for computing parameters and requests.
(flickcurl_call_get_one_string_field): Use flickcurl_add_param
etc.
(flickcurl_append_photos_list_params): Lose count param and use
flickcurl_add_param instead. Update all callers.
* src/favorites-api.c, src/galleries-api.c,
src/groups-pools-api.c, src/interestingness-api.c,
src/people-api.c, src/photos-api.c, src/photos-comments-api.c,
src/photos-geo-api.c, src/photosets-api.c, src/stats-api.c: Update
flickcurl_append_photos_list_params calls without parameters
* src/common.c, src/flickcurl_internal.h, src/legacy-auth.c,
src/oauth.c: Move parameters into flickcurl object as a fixed
array
(flickcurl_prepare_common, flickcurl_prepare_noauth,
flickcurl_prepare_upload, flickcurl_append_photos_list_params,
flickcurl_sort_args, flickcurl_oauth_prepare_common): Remove
parameters argument from multiple calls, replacing it with use of
fc->parameters
(flickcurl_call_get_one_string_field): use fc->parameters Declared
largest array of parameters once using
FLICKCURL_MAX_OAUTH_PARAM_COUNT and FLICKCURL_MAX_PARAM_COUNT
* src/config.c, src/flickcurl.h, src/oauth.c: Replace
flickcurl_set_oauth_client_credentials() with two calls
(flickcurl_set_oauth_client_key,
flickcurl_set_oauth_client_secret): Added.
* src/config.c:
(flickcurl_config_var_handler): client key/secret get switched
* src/oauth.c: Now legal C
* utils/flickcurl.c: Add oauth-create and oauth-verify commands to
invoke OAuth flow
(command_oauth_create): Added to create the request token/secret
(command_oauth_verify): Added to verify the request from the OAuth
frob to give the access tokens. Saves the OAuth tokens to the
config file too.
* src/oauth.c: Allow setting NULL fields in OAuth credential set
calls
(flickcurl_set_oauth_client_credentials,
flickcurl_set_oauth_token, flickcurl_set_oauth_token_secret,
flickcurl_set_oauth_request_credentials): Allow NULL args and
set/cleanup correctly.
2012-08-25 Dave Beckett <[email protected]>
* utils/flickcurl.c:
oauth docs
* utils/oauth-test.c: Just use public APIs
(oauth_prepare, oauth_test_echo): Removed
(main): Remove flickcurl_set_oauth_client_credentials - the client
key/secret must be in the configuration file now. Call
flickcurl_test_echo().
* utils/oauth-test.c:
Allow callback URI
* src/flickcurl.h, src/oauth.c, utils/oauth-test.c:
(flickcurl_oauth_create_request_token): Allow optional callback
* src/flickcurl.h, src/flickcurl_internal.h, src/oauth.c,
utils/oauth-test.c: Expose oauth authentication calls to public
API
(flickcurl_oauth_create_request_token): Made public, was
flickcurl_oauth_request_token internally.
(flickcurl_oauth_create_request_token): Was
flickcurl_oauth_request_token
(flickcurl_oauth_get_authorize_uri):
Made public.
(flickcurl_oauth_create_access_token): Made public,
was flickcurl_oauth_access_token internally.
(flickcurl_get_oauth_request_token,
flickcurl_get_oauth_request_token_secret,
flickcurl_set_oauth_request_credentials): Added to get/set the
request tokens.
* src/person.c:
(flickcurl_build_persons): Tidy up better on loop exit and error
path Fixed leaks of - xpathNodeCtx always - person object and
persons array on errors
* src/photo.c:
(flickcurl_build_photos): Fix leak of string_value for tags
* configure.ac:
Curl version line fix
2012-08-24 Dave Beckett <[email protected]>
* configure.ac: Use xml2-config and curl-config as well as
pkg-config
* src/common.c:
(flickcurl_prepare_common): Make legacy auth work again
* utils/flickcurl.c: OAuth
* src/config.c: oauth_token_secret
* src/config.c: Read oauth fields from config
* utils/oauth-test.c: Use flickcurl_set_oauth_client_credentials()
* src/flickcurl.h, src/oauth.c: Added getter/setters for OAuth
client key and secret
(flickcurl_get_oauth_client_key,
flickcurl_get_oauth_client_secret): Added getters
(flickcurl_set_oauth_client_credentials): Added setter.
* src/common.c:
docs
* src/auth-api.c:
(flickcurl_auth_oauth_getAccessToken): old secret becomes
client_secret
2012-08-23 Dave Beckett <[email protected]>
* src/oauth.c: Turn code into a check for test failure
* docs/tmpl/section-core.sgml: update tmpls
* src/reflection-api.c:
(flickcurl_reflection_getMethods): No auth needed
* docs/flickcurl-sections.txt: Added oauth get/setters
flickcurl_get_oauth_token flickcurl_get_oauth_token_secret
flickcurl_set_oauth_token flickcurl_set_oauth_token_secret
* src/Makefile.am, src/common.c, src/flickcurl_internal.h,
src/legacy-auth.c: Move legacy auth code to new module
src/legacy-auth.c
* src/common.c: Call legacy or OAuth to prepare and sign calls
(flickcurl_legacy_prepare_common): Renamed from
flickcurl_prepare_common.
(flickcurl_prepare_common): Call legacy Flickr Auth - above - or
OAuth via flickcurl_oauth_prepare_common.
* src/flickcurl_internal.h: docs for legacy auth fields
* src/auth-api.c:
(flickcurl_auth_getToken): Store exchanged OAuth token/secret
* utils/flickcurl.c: Document oauth_token and oauth_secret in
config
* src/config.c:
(flickcurl_config_write_ini): Write oauth fields if set
* src/common.c: Switch API Key source from fc->api_key to
fc->od.client_key Update docs to 'legacy Flickr auth' for
get/setters for legacy token and secret.
* src/flickcurl.h, src/oauth.c: Add get/setters for OAuth tokens
(flickcurl_get_oauth_token, flickcurl_set_oauth_token,
flickcurl_get_oauth_token_secret,
flickcurl_set_oauth_token_secret): Added
* configure.ac, src/Makefile.am, src/common.c,
src/flickcurl_internal.h, utils/Makefile.am: Enable OAuth support
always
* build/.gitignore, configure.ac: Add AM_PROG_AR for linking
2012-04-18 Dave Beckett <[email protected]>
* src/photos-api.c:
(flickcurl_photos_setDates): Actually send date_taken parameter
Fixes GitHub issue https://github.com/dajobe/flickcurl/issues/15
2012-03-11 Dave Beckett <[email protected]>
* src/flickcurl.h: Document sizes
2011-12-29 Dave Beckett <[email protected]>
* src/auth-api.c: 1.23
* NEWS.html: 1.23
* coverage.html: 1.22 and 1.23
2011-12-28 Dave Beckett <[email protected]>
* NEWS.html, configure.ac:
Bumped version to 1.23
2011-11-11 Dave Beckett <[email protected]>
* Snapshotted flickcurl_1_22 for 1.22 release (GIT
6698387f4240cec82b0e115adf8a863657dd7066)
* utils/oauth-test.c:
Update flickcurl_oauth_prepare_common call
* NEWS.html, src/common.c, src/flickcurl_internal.h: Disable
mtwist unless building experimental OAuth
* src/Makefile.am: Do not use libmtwist without oauth
* configure.ac, src/Makefile.am, src/common.c,
src/flickcurl_internal.h, utils/Makefile.am: Add --enable-oauth
default disabled
* src/common.c:
(flickcurl_free): Free OAuth urls
* src/oauth.c:
(test_signature_calc): Test free
* src/oauth.c: Make oauth test work again
* src/flickcurl_internal.h, src/oauth.c: Remove is_request arg -
just use od->callback
* src/common.c, src/flickcurl_internal.h, src/oauth.c,
utils/oauth-test.c: Move flickcurl_oauth_data into flickcurl
struct
* docs/flickcurl-docs.xml, docs/tmpl/section-config.sgml: Add
config section to docs
* autogen.sh, docs/tmpl/section-auth.sgml,
docs/tmpl/section-core.sgml, docs/tmpl/section-misc.sgml,
docs/tmpl/section-unused.sgml, docs/tmpl/section-upload.sgml,
libmtwist: Fix submodule checkouts
* autogen.sh: Init and update any git submodules
2011-11-09 Dave Beckett <[email protected]>
* src/flickcurl_internal.h, src/oauth.c:
Reduce visibility of oauth
internal functions These are internal to the library now because the
flickcurl_oauth_data is an internal structure.
2011-11-01 Dave Beckett <[email protected]>
* src/common.c: Return method details with curl errors
* src/Makefile.am: Clean tests
2011-10-30 Dave Beckett <[email protected]>
* utils/oauth-test.c: code style
* utils/oauth-test.c: casts
* src/oauth.c: docs
* src/oauth.c: consts
* docs/flickcurl-sections.txt: add oauth urls
* src/flickcurl_internal.h, src/oauth.c: fix const char keys
* src/oauth.c: docs
* src/oauth.c:
(flickcurl_oauth_access_token): Delete request token after success.
* src/oauth.c:
(flickcurl_oauth_build_key): Build sign key from request OR access
token
* utils/oauth-test.c: docs
* src/Makefile.am, src/oauth.c, utils/oauth-test.c: Add oauth
checksum test
* src/.gitignore: ignore *_test
2011-10-29 Dave Beckett <[email protected]>
* utils/oauth-test.c: Report request token
* src/oauth.c:
(flickcurl_oauth_prepare_common): docs and send all oauth params
except callback to requests
* src/flickcurl_internal.h, src/oauth.c, utils/oauth-test.c:
(flickcurl_oauth_access_token): Pass in verifier
* src/flickcurl_internal.h, src/oauth.c: request_token* fields
renamed from tmp_token*
* docs/flickcurl-sections.txt, src/auth-api.c, src/flickcurl.h:
Added flickr.auth.oauth.getAccessToken partial support
(flickcurl_auth_oauth_getAccessToken): Added for
flickr.auth.oauth.getAccessToken - right now it exchanges the old
tokens for OAuth ones and drops them both.
* src/flickcurl_internal.h, utils/oauth-test.c: oauth field
client_key_len renamed from client_len
* utils/oauth-test.c: FLICKCURL_MAX_OAUTH_PARAM_COUNT
* src/oauth.c: is_oauth_method fix
* src/flickcurl_internal.h, src/oauth.c:
FLICKCURL_MAX_OAUTH_PARAM_COUNT
* src/flickcurl.h, src/flickcurl_internal.h, src/oauth.c,
utils/oauth-test.c: Compute authorize URI after getting back oauth
request token (flickcurl_oauth_get_authorize_uri): Added.
* src/common.c, src/flickcurl_internal.h, src/oauth.c: Add utility
functions for oauth responses as HTTP forms
(flickcurl_invoke_get_form_content): Added to get content as k/v
array of strings.
(flickcurl_free_form): Added to free the above.
(flickcurl_oauth_request_token), flickcurl_oauth_access_token):
Use above.
* src/common.c, src/flickcurl_internal.h, src/oauth.c,
utils/Makefile.am, utils/oauth-test.c: Move OAuth test code into
oauth.c and refactor a little
* src/oauth.c:
(flickcurl_oauth_prepare_common): Do not use oath method name in
params
* libmtwist: Update to libmtwist head
* utils/oauth-test.c: Pass in (fake) flickr method for
flickcurl_oauth_prepare_common()
* src/oauth.c:
(flickcurl_oauth_prepare_common): Use http method not flickr method
* utils/oauth-test.c: remove unused srand()
* src/common.c, src/flickcurl_internal.h, src/oauth.c,
utils/oauth-test.c: Use libmtwist for PRNG for nonce
* libmtwist: Update to libmtwist head
* docs/flickcurl-sections.txt: Add symbols
* src/Makefile.am:
Add mtwist_config.h
* NEWS.html, docs/flickcurl-sections.txt:
flickcurl_get_hidden_from_string
* README.html: libmtwist submodule
2011-10-28 Dave Beckett <[email protected]>
* .gitmodules, configure.ac, libmtwist, src/Makefile.am,
src/mtwist_config.h: Add libmtwist as a git submodule
2011-10-16 Dave Beckett <[email protected]>
* src/oauth.c:
(flickcurl_oauth_compute_signature): Simplify greatly.
* src/config.c, src/flickcurl.h, utils/flickcurl.c:
(flickcurl_config_write_ini): Now writes to a filename
* utils/codegen.c, utils/flickcurl.c, utils/flickrdf.c,
utils/list-methods.c, utils/oauth-test.c: Update the utilities to
use flickcurl_config_ functions
* docs/flickcurl-sections.txt, src/common.c, src/config.c,
src/flickcurl.h: Update flickcurl config file reading and writing
support Move ini reading and writing into the library.
(flickcurl_config_read_ini): Added, deprecating read_ini_config()
and adding a flickcurl* param. Reads in library configuration.
(flickcurl_config_var_handler): Added as standard handler for
above.
(flickcurl_config_write_ini): Added to write an ini file for
library configuration.
* src/oauth.c:
(flickcurl_oauth_compute_signature): Docs and error path.
* configure.ac: Fix libcurl version check to actually check curl
not libxml twice
* configure.ac: Remove unused libcurl_min_vernum
* NEWS.html: Tim Harder is 'radhermit' on GitHub.
2011-10-15 Dave Beckett <[email protected]>
* NEWS.html: 1.22
* utils/flickcurl.c: Tidy help output; describe all upload params
defaults
* docs/flickcurl-sections.txt: Add flickcurl_get_hidden_label,
flickcurl_get_hidden_level_from_string
* src/common.c, src/flickcurl.h, src/upload-api.c,
utils/flickcurl.c: Add support for upload field 'hidden'
flickcurl_upload_params gains int param hidden with values 1 for
global and 2 for hidden.
(flickcurl_get_hidden_label, flickcurl_get_hidden_from_string):
Added utility functions to turn the int to a label and vice versa
* utils/flickcurl.c: Document upload params safety_level and
content_type
* docs/Makefile.am, docs/tmpl/section-favorite.sgml: Update tmpls
* docs/flickcurl-sections.txt:
Add flickcurl_favorites_getContext