Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

newest xgcm version breaks CI for python<3.9 #139

Closed
jbusecke opened this issue May 9, 2022 · 1 comment · Fixed by #141
Closed

newest xgcm version breaks CI for python<3.9 #139

jbusecke opened this issue May 9, 2022 · 1 comment · Fixed by #141

Comments

@jbusecke
Copy link
Owner

jbusecke commented May 9, 2022

I just noticed that some of our tests for 3.8 break, and this seems to be related to xgcm 0.7.0.

I guess the easiest solution is to bump to >=3.9 for now. But ultimately the xgcm_utils module should probably be refactored into another package (possibly into xgcm). This would release the dependency on xgcm here I believe.

I am not sure how many folks are relying on that module at the moment, so I will open a separate issue and discuss that over there.
@jbusecke jbusecke mentioned this issue May 9, 2022
Open
@jbusecke
Copy link
Owner Author

jbusecke commented May 9, 2022 •
edited
Loading

EDIT: Posted this in the wrong issue. The relevant issue is #140

Also cc'ing @TomNicholas here. Tom, there might be some bits of logic that might be helpful for xgcm.

@jbusecke jbusecke mentioned this issue May 9, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump python dependencies to >=3.9 jbusecke/xarrayutils
1 participant
@jbusecke