-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use of unsafePerformIO
#951
Comments
Hi! Judging by I don't see much harm in this call though. It simply looks at the first element of I'll merge a PR that refactors this, preferably in a way that doesn't change the existing type signatures (so add a new function, deprecate the old one). But I honestly don't think that this is worth an effort, so I'll close this issue now. |
https://github.com/jaspervdj/hakyll/blob/master/lib/Hakyll/Main.hs#L202
progName = unsafePerformIO getProgName
Is the use of
unsafePerformIO
necessary?Is there a reason this cannot be done safely, or was this a post-hoc addition?
I think refactoring it to be a safe call to
getProgName
would require modifying the functions which useprogName
.The text was updated successfully, but these errors were encountered: