Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes warnings of all GHC versions we have in CI, and also adds
-Werror
to CI so we don't backslide on this.Closes #939. I decided against dropping older GHC versions. Instead, I simply document the current state of things: Hakyll already fails to build with GHC 8.4 due to template-haskell requirement, so our CI will only test 8.6+. My goal for now is to keep each GHC version supported for as long as it's feasible, i.e. our dependencies support it and it doesn't create too much work for us to support it too.