Fix all GHC warnings #955
Merged
Fix all GHC warnings #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e01ff99
to
921a6e7
Compare
f38bf46
to
c76b5a6
Compare
|
Windows build fails because of unlucky timing: hfsnotify 0.4.0.1 is currently broken on Windows. The fixes are already in master though (haskell-fswatch/hfsnotify#107), so I'll wait for a new release and re-start the CI runs here. |
c76b5a6
to
2b9ca3c
Compare
Hakyll already failed to build on earlier versions due to the template-haskell requirement, and nobody complained about that, so I assume nobody cares if the support is properly dropped.
8d008ff
to
71c7562
Compare
71c7562
to
05001da
Compare
This is only done for combinations where we aren't at fault, e.g. an older GHC doesn't work on a newer macOS.
4b63b6d
to
9e58219
Compare
|
This finally passes CI! I'll wait a day or two, do a self-review, and merge. Reviews from others are welcome too! |
|
Well this looks good enough, even if I say so myself :) Let's merge it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes warnings of all GHC versions we have in CI, and also adds
-Werrorto CI so we don't backslide on this.Closes #939. I decided against dropping older GHC versions. Instead, I simply document the current state of things: Hakyll already fails to build with GHC 8.4 due to template-haskell requirement, so our CI will only test 8.6+. My goal for now is to keep each GHC version supported for as long as it's feasible, i.e. our dependencies support it and it doesn't create too much work for us to support it too.