Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Support for Particular Files in Gist #2

Closed
rahulrsingh09 opened this issue Aug 22, 2017 · 4 comments
Closed

Adding Support for Particular Files in Gist #2

rahulrsingh09 opened this issue Aug 22, 2017 · 4 comments
Assignees

Comments

@rahulrsingh09
Copy link
Collaborator

Hi Jason

Thanks for this awsome plugin , however my requirement was i wanted to read a particular file from my gist which had many .

I have extended this library by forking it to add file support . Hope you like it
Added File support

@jasonhodges
Copy link
Owner

Hi @rahulrsingh09
Took a quick look and I think it is fine. Do you plan to submit a pull request?

@jasonhodges jasonhodges self-assigned this Aug 23, 2017
@rahulrsingh09
Copy link
Collaborator Author

rahulrsingh09 commented Aug 23, 2017

Hi @jasonhodges would love to add a PR .
One thing is that when a user selects a file option we need to remove the body and add a div as body takes up a lot of unnecessary space . I had forked and made the change , shall i clone it and make a change and have a new branch for that i might need contributer
access ?

Also @jasonhodges if you tell me how to pack it as presently when i first load the app it says ERROR in NgxGistModule is not an NgModule and then if i build again it works . i just did a npm install and created a dist but what is the general way of packing .

image

This is the error image Please check

@jasonhodges
Copy link
Owner

@rahulrsingh09
I have added you to a gitter channel, lets chat there

@jasonhodges
Copy link
Owner

closing after successful merge of PR #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants