Set min node.js version to 6.9 #918
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you opened an issue there: webpack/webpack#6579 Can you please set min version to |
In jantimon#861 support for nodejs < 6 was dropped. However, the minimal version was to 6.11.5 for no clear reason. This excludes version v6.11.4 from current Ubuntu 17.10 as well as version 6.10.3 running on AWS Lambda. See also discussion in webpack/webpack#6579
webmaster128
force-pushed
the
node-version
branch
from
a27f1e6
to
038773d
Compare
|
Thanks for feedback, updated |
webmaster128
changed the title
jantimon
pushed a commit
that referenced
this pull request
Apr 3, 2018
In #861 support for nodejs < 6 was dropped. However, the minimal version was to 6.11.5 for no clear reason. This excludes version v6.11.4 from current Ubuntu 17.10 as well as version 6.10.3 running on AWS Lambda. See also discussion in webpack/webpack#6579 #918
|
I also set the travis version to 6.9 and will merge it as soon as travis is happy :) |
jantimon
pushed a commit
that referenced
this pull request
Apr 3, 2018
In #861 support for nodejs < 6 was dropped. However, the minimal version was to 6.11.5 for no clear reason. This excludes version v6.11.4 from current Ubuntu 17.10 as well as version 6.10.3 running on AWS Lambda. See also discussion in webpack/webpack#6579 #918
|
Merged into 3.2.0 |
|
Thanks! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #861 support for nodejs < 6 was dropped. However, the minimal version was to 6.11.5 for no clear reason. This excludes version v6.11.4 from current Ubuntu 17.10 as well as version 6.10.3 running on AWS Lambda.
If features newer then 6.0.0 are needed, we should only set the minor version, not the patch level, e.g. 6.11.0 instead of 6.11.5 because Linux distributions often apply patches to a fixed version, so v6.11.4 on Ubuntu is likely to have all security fixes that are in 6.11.5.